From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Date: Fri, 11 Aug 2017 11:32:43 -0700 Message-ID: <20170811183243.GB109008@google.com> References: <20170717195854.192139-1-mka@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x22e.google.com (mail-pg0-x22e.google.com [IPv6:2607:f8b0:400e:c05::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6284F6E72F for ; Fri, 11 Aug 2017 18:32:45 +0000 (UTC) Received: by mail-pg0-x22e.google.com with SMTP id l64so18445985pge.5 for ; Fri, 11 Aug 2017 11:32:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170717195854.192139-1-mka@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Manasi Navare , rodrigo.vivi@intel.com, clinton.a.taylor@intel.com Cc: Grant Grundler , intel-gfx , Linux Kernel Mailing List , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RWwgTW9uLCBKdWwgMTcsIDIwMTcgYXQgMTI6NTg6NTRQTSAtMDcwMCBNYXR0aGlhcyBLYWVobGNr ZSBoYSBkaXQ6Cgo+IEZvciAwLjg1ViBjbmxfZ2V0X2J1Zl90cmFuc19lZHAoKSByZXR1cm5zIHRo ZSBEUCB0YWJsZSwgaW5zdGVhZCBvZiBFRFAuCj4gVXNlIHRoZSBjb3JyZWN0IHRhYmxlLgo+IAo+ IFRoZSBlcnJvciB3YXMgcG9pbnRlZCBvdXQgYnkgdGhpcyBjbGFuZyB3YXJuaW5nOgo+IAo+IGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jOjM5MjozOTogd2FybmluZzogdmFyaWFibGUK PiAgICdjbmxfZGRpX3RyYW5zbGF0aW9uc19lZHBfMF84NVYnIGlzIG5vdCBuZWVkZWQgYW5kIHdp bGwgbm90IGJlIGVtaXR0ZWQKPiAgIFstV3VubmVlZGVkLWludGVybmFsLWRlY2xhcmF0aW9uXQo+ ICAgICBzdGF0aWMgY29uc3Qgc3RydWN0IGNubF9kZGlfYnVmX3RyYW5zIGNubF9kZGlfdHJhbnNs YXRpb25zX2VkcF8wXzg1VltdID0gewo+IAo+IEZpeGVzOiBjZjU0Y2E4YmM1NjcgKCJkcm0vaTkx NS9jbmw6IEltcGxlbWVudCB2b2x0YWdlIHN3aW5nIHNlcXVlbmNlLiIpCj4gU2lnbmVkLW9mZi1i eTogTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJvbWl1bS5vcmc+Cj4gUmV2aWV3ZWQtYnk6IE1h bmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBp biB2MjoKPiAtIEFkZGVkICdGaXhlcycgdGFnCj4gLSBBZGRlZCBSZXZpZXdlZC1ieTogTWFuYXNp IE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KCnBpbmcsIGl0IHNlZW1zIHRoaXMg cGF0Y2ggd2VudCB1bmRlciB0aGUgcmFkYXIuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbdHKScq (ORCPT ); Fri, 11 Aug 2017 14:32:46 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:36098 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdHKScp (ORCPT ); Fri, 11 Aug 2017 14:32:45 -0400 Date: Fri, 11 Aug 2017 11:32:43 -0700 From: Matthias Kaehlcke To: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Manasi Navare , rodrigo.vivi@intel.com, clinton.a.taylor@intel.com Cc: intel-gfx , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Grant Grundler Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Message-ID: <20170811183243.GB109008@google.com> References: <20170717195854.192139-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170717195854.192139-1-mka@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit: > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > Use the correct table. > > The error was pointed out by this clang warning: > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Manasi Navare > --- > Changes in v2: > - Added 'Fixes' tag > - Added Reviewed-by: Manasi Navare ping, it seems this patch went under the radar.