Re: [rdma-next 08/22] RDMA/core: Delete BUG() from unreachable flow

[Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Sun, Aug 13, 2017 at 02:00:17PM +0300, Leon Romanovsky wrote:
> On Sun, Aug 13, 2017 at 01:51:41PM +0300, Yuval Shaia wrote:
> > On Sun, Aug 13, 2017 at 01:29:04PM +0300, Leon Romanovsky wrote:
> > > On Sun, Aug 13, 2017 at 01:21:17PM +0300, Yuval Shaia wrote:
> > > > On Fri, Aug 11, 2017 at 01:49:49PM +0300, Leon Romanovsky wrote:
> > > > > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > > > >
> > > > > Remove call to BUG() in case wrong node_type was provided.
> > > > > This flow is unreachable, because node_types are supplied
> > > > > from specific enum.
> > > > >
> > > > > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > > > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > > > > ---
> > > > >  drivers/infiniband/core/verbs.c | 14 +++++---------
> > > > >  1 file changed, 5 insertions(+), 9 deletions(-)
> > > > >
> > > > > diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
> > > > > index 21fef6b6d4f3..0d359a482b13 100644
> > > > > --- a/drivers/infiniband/core/verbs.c
> > > > > +++ b/drivers/infiniband/core/verbs.c
> > > > > @@ -180,17 +180,13 @@ EXPORT_SYMBOL(ib_rate_to_mbps);
> > > > >  __attribute_const__ enum rdma_transport_type
> > > > >  rdma_node_get_transport(enum rdma_node_type node_type)
> > > > >  {
> > > > > -	switch (node_type) {
> > > > > -	case RDMA_NODE_IB_CA:
> > > > > +	if (node_type == RDMA_NODE_IB_CA)
> > > > >  		return RDMA_TRANSPORT_IB;
> > > > > -	case RDMA_NODE_RNIC:
> > > > > +
> > > > > +	if (node_type == RDMA_NODE_RNIC)
> > > > >  		return RDMA_TRANSPORT_IWARP;
> > > >
> > > > Looking at for-next, there is case for RDMA_NODE_USNIC.
> > > > Which branch this patch is based on?
> > >
> > > for-next, in case of RDMA_NODE_USNIC, we are using the
> > > RDMA_TRANSPORT_USNIC_UDP return type.
> >
> > I see, but then i would expect to see these lines in the patch:
> > -	case RDMA_NODE_USNIC:
> > -		return RDMA_TRANSPORT_USNIC;
> 
> Please see patch #7 from this series.

Oops,

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> 
> Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html