All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation
Date: Sun, 13 Aug 2017 17:59:41 -0400	[thread overview]
Message-ID: <20170813215941.GU20467@bill-the-cat> (raw)
In-Reply-To: <CAF6AEGs=gvmxAC6-mQYD+vBLGAVdQ2O5hiVLC8fUOYvo3LydTQ@mail.gmail.com>

On Sun, Aug 13, 2017 at 05:50:39PM -0400, Rob Clark wrote:
> On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote:
> >
> >> Introduce directory traversal iterators, and implement fs_readdir()
> >> which is needed by EFI_LOADER.
> >>
> >> The part re-working fat.c to use the directory iterators itself is
> >> nearly a 2:1 negative diffstat, and a pretty big cleanup.  I fixed
> >> one or two other small issues along the way.  It hasn't really been
> >> tested with a wide variaty of different fat filesystems (if someone
> >> has a collection of disk images to test with somewhere, let me know),
> >> but it seems at least not worse than what it is replacing.
> >
> > Did you run test/fs/fs-test.sh and confirm there's at least no
> > regressions?  Thanks!
> 
> I've been having trouble getting fs-test.sh to pass even without my
> changes, so no..

Pass, or provide expected results?  From the script, we expect:
# Total Summary: TOTAL PASS: 132 TOTAL FAIL: 6

> Not entirely sure if I have newer kernel/etc compared to the last
> person who ran fs-test.sh, or if there is something on u-boot side
> which changed without corresponding change in fs-test.sh.

Note that this script it part of my
everything-my-lab-isn't-giving-me-fits loop.  I'm probably going to
split that loop into pure-SW and HW, as the HW part is what's driving me
crazy most of the time.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170813/c2742512/attachment.sig>

  reply	other threads:[~2017-08-13 21:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-13 10:45 [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 1/8] fs/fat: split out helper to init fsdata Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 2/8] fs/fat: introduce new director iterators Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 3/8] fat/fs: convert to directory iterators Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 4/8] fs: add fs_readdir() Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 5/8] fs/fat: implement opendir/readdir/closedir Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 6/8] fat/fs: remove a bunch of dead code Rob Clark
2017-08-13 11:11   ` Stefan Bruens
2017-08-13 10:45 ` [U-Boot] [PATCH 7/8] fat/fs: move ls to generic implementation Rob Clark
2017-08-13 10:45 ` [U-Boot] [PATCH 8/8] fs/fat: fix case for FAT shortnames Rob Clark
2017-08-13 11:25   ` Stefan Bruens
2017-08-13 12:14     ` Rob Clark
2017-08-13 18:09   ` [U-Boot] [PATCH v2 " Rob Clark
2017-08-13 11:28 ` [U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation Heinrich Schuchardt
2017-08-13 12:13   ` Rob Clark
2017-08-13 21:13 ` Tom Rini
2017-08-13 21:50   ` Rob Clark
2017-08-13 21:59     ` Tom Rini [this message]
2017-08-14 12:48       ` Rob Clark
2017-08-14 13:05         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170813215941.GU20467@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.