From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhGmb-0005r8-CB for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:55:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhGmY-0007Yw-Oi for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:55:57 -0400 Received: from smtp.citrix.com ([66.165.176.89]:17879) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhGmY-0007Xl-Ij for qemu-devel@nongnu.org; Mon, 14 Aug 2017 10:55:54 -0400 Date: Mon, 14 Aug 2017 15:55:50 +0100 From: Anthony PERARD Message-ID: <20170814145550.GA1475@perard.uk.xensource.com> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170811201006-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Bruce Rogers , Igor Mammedov , Paolo Bonzini , Richard Henderson , Eduardo Habkost On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > set, but this was done only when ACPI tables are built which is not > > needed for a Xen guest. The need for the property starts with commit > > "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice" > > (f0c9d64a68b776374ec4732424a3e27753ce37b6). > > > > Set pci info before checking for the needs to build ACPI tables. > > > > Reported-by: Sander Eikelenboom > > Tested-by: Sander Eikelenboom > > Signed-off-by: Anthony PERARD > > I am worried that Xen will come to depend on specific > assignment of bsel which isn't guaranteed. Thoughts on > how to avoid that? Is it possible to have a different BSEL than 0 with PIIX ? Also, I don't known if having more than on PCI bus is going to work on Xen, there is nothing in our ACPI tables beyond _SB.PCI0, and nothing to use a different BSEL. > > > > --- > > In this patch rather than always calling acpi_set_pci_info() when > > acpi_setup() is called, we could check first for acpi_enabled? (which is > > true for Xen.) > > Yes, please change it like this. Also, please add > a comment explainging what it does. Will do. -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed Date: Mon, 14 Aug 2017 15:55:50 +0100 Message-ID: <20170814145550.GA1475@perard.uk.xensource.com> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhGmY-0000ay-Sg for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 14:55:54 +0000 Content-Disposition: inline In-Reply-To: <20170811201006-mutt-send-email-mst@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: "Michael S. Tsirkin" Cc: Stefano Stabellini , Eduardo Habkost , qemu-devel@nongnu.org, Bruce Rogers , Paolo Bonzini , Igor Mammedov , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBBdWcgMTEsIDIwMTcgYXQgMDg6MTg6MjhQTSArMDMwMCwgTWljaGFlbCBTLiBUc2ly a2luIHdyb3RlOgo+IE9uIEZyaSwgQXVnIDExLCAyMDE3IGF0IDA0OjExOjM3UE0gKzAxMDAsIEFu dGhvbnkgUEVSQVJEIHdyb3RlOgo+ID4gVG8gZG8gUENJIHBhc3N0aHJvdWdoIHdpdGggWGVuLCB0 aGUgcHJvcGVydHkgYWNwaS1wY2locC1ic2VsIG5lZWRzIHRvIGJlCj4gPiBzZXQsIGJ1dCB0aGlz IHdhcyBkb25lIG9ubHkgd2hlbiBBQ1BJIHRhYmxlcyBhcmUgYnVpbHQgd2hpY2ggaXMgbm90Cj4g PiBuZWVkZWQgZm9yIGEgWGVuIGd1ZXN0LiBUaGUgbmVlZCBmb3IgdGhlIHByb3BlcnR5IHN0YXJ0 cyB3aXRoIGNvbW1pdAo+ID4gInBjOiBwY2locDogYXZvaWQgYWRkaW5nIEFDUElfUENJSFBfUFJP UF9CU0VMIHR3aWNlIgo+ID4gKGYwYzlkNjRhNjhiNzc2Mzc0ZWM0NzMyNDI0YTNlMjc3NTNjZTM3 YjYpLgo+ID4gCj4gPiBTZXQgcGNpIGluZm8gYmVmb3JlIGNoZWNraW5nIGZvciB0aGUgbmVlZHMg dG8gYnVpbGQgQUNQSSB0YWJsZXMuCj4gPiAKPiA+IFJlcG9ydGVkLWJ5OiBTYW5kZXIgRWlrZWxl bmJvb20gPGxpbnV4QGVpa2VsZW5ib29tLml0Pgo+ID4gVGVzdGVkLWJ5OiBTYW5kZXIgRWlrZWxl bmJvb20gPGxpbnV4QGVpa2VsZW5ib29tLml0Pgo+ID4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQ RVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+Cj4gCj4gSSBhbSB3b3JyaWVkIHRoYXQg WGVuIHdpbGwgY29tZSB0byBkZXBlbmQgb24gc3BlY2lmaWMKPiBhc3NpZ25tZW50IG9mIGJzZWwg d2hpY2ggaXNuJ3QgZ3VhcmFudGVlZC4gVGhvdWdodHMgb24KPiBob3cgdG8gYXZvaWQgdGhhdD8K CklzIGl0IHBvc3NpYmxlIHRvIGhhdmUgYSBkaWZmZXJlbnQgQlNFTCB0aGFuIDAgd2l0aCBQSUlY ID8KQWxzbywgSSBkb24ndCBrbm93biBpZiBoYXZpbmcgbW9yZSB0aGFuIG9uIFBDSSBidXMgaXMg Z29pbmcgdG8gd29yayBvbgpYZW4sIHRoZXJlIGlzIG5vdGhpbmcgaW4gb3VyIEFDUEkgdGFibGVz IGJleW9uZCBfU0IuUENJMCwgYW5kIG5vdGhpbmcgdG8KdXNlIGEgZGlmZmVyZW50IEJTRUwuCgo+ ID4gCj4gPiAtLS0KPiA+IEluIHRoaXMgcGF0Y2ggcmF0aGVyIHRoYW4gYWx3YXlzIGNhbGxpbmcg YWNwaV9zZXRfcGNpX2luZm8oKSB3aGVuCj4gPiBhY3BpX3NldHVwKCkgaXMgY2FsbGVkLCB3ZSBj b3VsZCBjaGVjayBmaXJzdCBmb3IgYWNwaV9lbmFibGVkPyAod2hpY2ggaXMKPiA+IHRydWUgZm9y IFhlbi4pCj4gCj4gWWVzLCBwbGVhc2UgY2hhbmdlIGl0IGxpa2UgdGhpcy4gQWxzbywgcGxlYXNl IGFkZAo+IGEgY29tbWVudCBleHBsYWluZ2luZyB3aGF0IGl0IGRvZXMuCgpXaWxsIGRvLgoKLS0g CkFudGhvbnkgUEVSQVJECgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0 dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK