From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhHg9-0002Gj-Ah for qemu-devel@nongnu.org; Mon, 14 Aug 2017 11:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhHg5-0004Zv-5n for qemu-devel@nongnu.org; Mon, 14 Aug 2017 11:53:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41128) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhHg5-0004Zf-0G for qemu-devel@nongnu.org; Mon, 14 Aug 2017 11:53:17 -0400 Date: Mon, 14 Aug 2017 18:53:14 +0300 From: "Michael S. Tsirkin" Message-ID: <20170814185150-mutt-send-email-mst@kernel.org> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> <20170814145550.GA1475@perard.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170814145550.GA1475@perard.uk.xensource.com> Subject: Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Bruce Rogers , Igor Mammedov , Paolo Bonzini , Richard Henderson , Eduardo Habkost On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote: > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > > set, but this was done only when ACPI tables are built which is not > > > needed for a Xen guest. The need for the property starts with commit > > > "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice" > > > (f0c9d64a68b776374ec4732424a3e27753ce37b6). > > > > > > Set pci info before checking for the needs to build ACPI tables. > > > > > > Reported-by: Sander Eikelenboom > > > Tested-by: Sander Eikelenboom > > > Signed-off-by: Anthony PERARD > > > > I am worried that Xen will come to depend on specific > > assignment of bsel which isn't guaranteed. Thoughts on > > how to avoid that? > > Is it possible to have a different BSEL than 0 with PIIX ? With PCI to PCI bridges, yes. > Also, I don't known if having more than on PCI bus is going to work on > Xen, there is nothing in our ACPI tables beyond _SB.PCI0, and nothing to > use a different BSEL. My worry is someone might decide to implement hotplug for pci to pci bridges on Xen. If doing that, it's important to use the qemu supplied acpi tables. > > > > > > --- > > > In this patch rather than always calling acpi_set_pci_info() when > > > acpi_setup() is called, we could check first for acpi_enabled? (which is > > > true for Xen.) > > > > Yes, please change it like this. Also, please add > > a comment explainging what it does. > > Will do. > > -- > Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed Date: Mon, 14 Aug 2017 18:53:14 +0300 Message-ID: <20170814185150-mutt-send-email-mst@kernel.org> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> <20170814145550.GA1475@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhHg7-0005lK-9b for xen-devel@lists.xenproject.org; Mon, 14 Aug 2017 15:53:19 +0000 Content-Disposition: inline In-Reply-To: <20170814145550.GA1475@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Stefano Stabellini , Eduardo Habkost , qemu-devel@nongnu.org, Bruce Rogers , Paolo Bonzini , Igor Mammedov , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBBdWcgMTQsIDIwMTcgYXQgMDM6NTU6NTBQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gT24gRnJpLCBBdWcgMTEsIDIwMTcgYXQgMDg6MTg6MjhQTSArMDMwMCwgTWljaGFl bCBTLiBUc2lya2luIHdyb3RlOgo+ID4gT24gRnJpLCBBdWcgMTEsIDIwMTcgYXQgMDQ6MTE6MzdQ TSArMDEwMCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6Cj4gPiA+IFRvIGRvIFBDSSBwYXNzdGhyb3Vn aCB3aXRoIFhlbiwgdGhlIHByb3BlcnR5IGFjcGktcGNpaHAtYnNlbCBuZWVkcyB0byBiZQo+ID4g PiBzZXQsIGJ1dCB0aGlzIHdhcyBkb25lIG9ubHkgd2hlbiBBQ1BJIHRhYmxlcyBhcmUgYnVpbHQg d2hpY2ggaXMgbm90Cj4gPiA+IG5lZWRlZCBmb3IgYSBYZW4gZ3Vlc3QuIFRoZSBuZWVkIGZvciB0 aGUgcHJvcGVydHkgc3RhcnRzIHdpdGggY29tbWl0Cj4gPiA+ICJwYzogcGNpaHA6IGF2b2lkIGFk ZGluZyBBQ1BJX1BDSUhQX1BST1BfQlNFTCB0d2ljZSIKPiA+ID4gKGYwYzlkNjRhNjhiNzc2Mzc0 ZWM0NzMyNDI0YTNlMjc3NTNjZTM3YjYpLgo+ID4gPiAKPiA+ID4gU2V0IHBjaSBpbmZvIGJlZm9y ZSBjaGVja2luZyBmb3IgdGhlIG5lZWRzIHRvIGJ1aWxkIEFDUEkgdGFibGVzLgo+ID4gPiAKPiA+ ID4gUmVwb3J0ZWQtYnk6IFNhbmRlciBFaWtlbGVuYm9vbSA8bGludXhAZWlrZWxlbmJvb20uaXQ+ Cj4gPiA+IFRlc3RlZC1ieTogU2FuZGVyIEVpa2VsZW5ib29tIDxsaW51eEBlaWtlbGVuYm9vbS5p dD4KPiA+ID4gU2lnbmVkLW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNp dHJpeC5jb20+Cj4gPiAKPiA+IEkgYW0gd29ycmllZCB0aGF0IFhlbiB3aWxsIGNvbWUgdG8gZGVw ZW5kIG9uIHNwZWNpZmljCj4gPiBhc3NpZ25tZW50IG9mIGJzZWwgd2hpY2ggaXNuJ3QgZ3VhcmFu dGVlZC4gVGhvdWdodHMgb24KPiA+IGhvdyB0byBhdm9pZCB0aGF0Pwo+IAo+IElzIGl0IHBvc3Np YmxlIHRvIGhhdmUgYSBkaWZmZXJlbnQgQlNFTCB0aGFuIDAgd2l0aCBQSUlYID8KCldpdGggUENJ IHRvIFBDSSBicmlkZ2VzLCB5ZXMuCgo+IEFsc28sIEkgZG9uJ3Qga25vd24gaWYgaGF2aW5nIG1v cmUgdGhhbiBvbiBQQ0kgYnVzIGlzIGdvaW5nIHRvIHdvcmsgb24KPiBYZW4sIHRoZXJlIGlzIG5v dGhpbmcgaW4gb3VyIEFDUEkgdGFibGVzIGJleW9uZCBfU0IuUENJMCwgYW5kIG5vdGhpbmcgdG8K PiB1c2UgYSBkaWZmZXJlbnQgQlNFTC4KCk15IHdvcnJ5IGlzIHNvbWVvbmUgbWlnaHQgZGVjaWRl IHRvIGltcGxlbWVudCBob3RwbHVnIGZvciBwY2kgdG8gcGNpCmJyaWRnZXMgb24gWGVuLiBJZiBk b2luZyB0aGF0LCBpdCdzIGltcG9ydGFudCB0byB1c2UgdGhlIHFlbXUgc3VwcGxpZWQKYWNwaSB0 YWJsZXMuCgo+ID4gPiAKPiA+ID4gLS0tCj4gPiA+IEluIHRoaXMgcGF0Y2ggcmF0aGVyIHRoYW4g YWx3YXlzIGNhbGxpbmcgYWNwaV9zZXRfcGNpX2luZm8oKSB3aGVuCj4gPiA+IGFjcGlfc2V0dXAo KSBpcyBjYWxsZWQsIHdlIGNvdWxkIGNoZWNrIGZpcnN0IGZvciBhY3BpX2VuYWJsZWQ/ICh3aGlj aCBpcwo+ID4gPiB0cnVlIGZvciBYZW4uKQo+ID4gCj4gPiBZZXMsIHBsZWFzZSBjaGFuZ2UgaXQg bGlrZSB0aGlzLiBBbHNvLCBwbGVhc2UgYWRkCj4gPiBhIGNvbW1lbnQgZXhwbGFpbmdpbmcgd2hh dCBpdCBkb2VzLgo+IAo+IFdpbGwgZG8uCj4gCj4gLS0gCj4gQW50aG9ueSBQRVJBUkQKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hl bi1kZXZlbAo=