From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: [PATCH 4.9 16/41] drm/i915: Fix out-of-bounds array access in bdw_load_gamma_lut Date: Mon, 14 Aug 2017 18:18:26 -0700 Message-ID: <20170815011809.594179167@linuxfoundation.org> References: <20170815011808.667221255@linuxfoundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85D0389DB0 for ; Tue, 15 Aug 2017 01:19:16 +0000 (UTC) In-Reply-To: <20170815011808.667221255@linuxfoundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-kernel@vger.kernel.org Cc: Jani Nikula , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Kausal Malladi , Daniel Vetter , Kiran S Kumar List-Id: intel-gfx@lists.freedesktop.org NC45LXN0YWJsZSByZXZpZXcgcGF0Y2guICBJZiBhbnlvbmUgaGFzIGFueSBvYmplY3Rpb25zLCBw bGVhc2UgbGV0IG1lIGtub3cuCgotLS0tLS0tLS0tLS0tLS0tLS0KCkZyb206IE1hYXJ0ZW4gTGFu a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cgpjb21taXQgNTI3OWZj NzcyNGFlM2E4MmM5Y2ZlNWIwOWMxZmIwN2ZmMGU0MTA1NiB1cHN0cmVhbS4KCmJkd19sb2FkX2dh bW1hX2x1dCBpcyB3cml0aW5nIGJleW9uZCB0aGUgYXJyYXkgdG8gdGhlIG1heGltdW0gdmFsdWUu ClRoZSBpbnRlbmQgb2YgdGhlIGZ1bmN0aW9uIGlzIHRvIGNsYW1wIHZhbHVlcyA+IDEgdG8gMSwg c28gd3JpdGUKdGhlIGludGVuZGVkIGNvbG9yIHRvIHRoZSBtYXggcmVnaXN0ZXIuCgpUaGlzIGZp eGVzIHRoZSBmb2xsb3dpbmcgS0FTQU4gd2FybmluZzoKClsgIDE5Ny4wMjA4NTddIFtJR1RdIGtt c19waXBlX2NvbG9yOiBleGVjdXRpbmcKWyAgMTk3LjA2MzQzNF0gW0lHVF0ga21zX3BpcGVfY29s b3I6IHN0YXJ0aW5nIHN1YnRlc3QgY3RtLTAtMjUtcGlwZTAKWyAgMTk3LjA3ODk4OV0gPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClsgIDE5Ny4wNzkxMjddIEJVRzogS0FTQU46IHNsYWItb3V0LW9mLWJvdW5kcyBpbiBiZHdf bG9hZF9nYW1tYV9sdXQuaXNyYS4yKzB4M2I5LzB4NTcwIFtpOTE1XQpbICAxOTcuMDc5MTg4XSBS ZWFkIG9mIHNpemUgMiBhdCBhZGRyIGZmZmY4ODAwZDM4ZGIxNTAgYnkgdGFzayBrbXNfcGlwZV9j b2xvci8xODM5ClsgIDE5Ny4wNzkyMDhdIENQVTogMiBQSUQ6IDE4MzkgQ29tbToga21zX3BpcGVf Y29sb3IgVGFpbnRlZDogRyAgICAgVSA0LjEzLjAtcmMxLXBhdHNlcisgIzUyMTEKWyAgMTk3LjA3 OTIxNV0gSGFyZHdhcmUgbmFtZTogTlVDNWk3UllCLCBCSU9TIFJZQkRXaTM1Ljg2QS4wMjQ2LjIw MTUuMDMwOS4xMzU1IDAzLzA5LzIwMTUKWyAgMTk3LjA3OTIyMF0gQ2FsbCBUcmFjZToKWyAgMTk3 LjA3OTIzMF0gIGR1bXBfc3RhY2srMHg2OC8weDllClsgIDE5Ny4wNzkyMzldICBwcmludF9hZGRy ZXNzX2Rlc2NyaXB0aW9uKzB4NmYvMHgyNTAKWyAgMTk3LjA3OTI1MV0gIGthc2FuX3JlcG9ydCsw eDIxNi8weDM3MApbICAxOTcuMDc5Mzc0XSAgPyBiZHdfbG9hZF9nYW1tYV9sdXQuaXNyYS4yKzB4 M2I5LzB4NTcwIFtpOTE1XQpbICAxOTcuMDc5NDUxXSAgPyBnZW44X3dyaXRlMTYrMHg0ZTAvMHg0 ZTAgW2k5MTVdClsgIDE5Ny4wNzk0NjBdICBfX2FzYW5fcmVwb3J0X2xvYWQyX25vYWJvcnQrMHgx NC8weDIwClsgIDE5Ny4wNzk1MzVdICBiZHdfbG9hZF9nYW1tYV9sdXQuaXNyYS4yKzB4M2I5LzB4 NTcwIFtpOTE1XQpbICAxOTcuMDc5NjEyXSAgYnJvYWR3ZWxsX2xvYWRfbHV0cysweDFkZi8weDU1 MCBbaTkxNV0KWyAgMTk3LjA3OTY5MF0gIGludGVsX2NvbG9yX2xvYWRfbHV0cysweDdiLzB4ODAg W2k5MTVdClsgIDE5Ny4wNzk3NjRdICBpbnRlbF9iZWdpbl9jcnRjX2NvbW1pdCsweDEzOC8weDc2 MCBbaTkxNV0KWyAgMTk3LjA3OTc4M10gIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9wbGFuZXNf b25fY3J0YysweDFhMy8weDgyMCBbZHJtX2ttc19oZWxwZXJdClsgIDE5Ny4wNzk4NTldICA/IGlu dGVsX3ByZV9wbGFuZV91cGRhdGUrMHg1NzEvMHg1ODAgW2k5MTVdClsgIDE5Ny4wNzk5MzddICBp bnRlbF91cGRhdGVfY3J0YysweDIzOC8weDMzMCBbaTkxNV0KWyAgMTk3LjA4MDAxNl0gIGludGVs X3VwZGF0ZV9jcnRjcysweDEwZi8weDIxMCBbaTkxNV0KWyAgMTk3LjA4MDA5Ml0gIGludGVsX2F0 b21pY19jb21taXRfdGFpbCsweDE1NTIvMHgzMzQwIFtpOTE1XQpbICAxOTcuMDgwMTAxXSAgPyBf cmF3X3NwaW5fdW5sb2NrKzB4M2MvMHg0MApbICAxOTcuMDgwMTEwXSAgPyBfX3F1ZXVlX3dvcmsr MHhiNDAvMHhiZjAKWyAgMTk3LjA4MDE4OF0gID8gc2tsX3VwZGF0ZV9jcnRjcysweGMwMC8weGMw MCBbaTkxNV0KWyAgMTk3LjA4MDE5NV0gID8gdHJhY2VfaGFyZGlycXNfb24rMHhkLzB4MTAKWyAg MTk3LjA4MDI2OV0gID8gaW50ZWxfYXRvbWljX2NvbW1pdF9yZWFkeSsweDEyOC8weDEzYyBbaTkx NV0KWyAgMTk3LjA4MDMyOV0gID8gX19pOTE1X3N3X2ZlbmNlX2NvbXBsZXRlKzB4NWI4LzB4NmQw IFtpOTE1XQpbICAxOTcuMDgwMzM2XSAgPyBkZWJ1Z19vYmplY3RfYWN0aXZhdGUrMHgzOWUvMHg1 ODAKWyAgMTk3LjA4MDM5N10gID8gaTkxNV9zd19mZW5jZV9hd2FpdCsweDMwLzB4MzAgW2k5MTVd ClsgIDE5Ny4wODA0MDldICA/IF9fbWlnaHRfc2xlZXArMHgxNWIvMHgxODAKWyAgMTk3LjA4MDQ4 M10gIGludGVsX2F0b21pY19jb21taXQrMHg5NDQvMHhhNzAgW2k5MTVdClsgIDE5Ny4wODA0OTBd ICA/IHJlZmNvdW50X2RlY19hbmRfdGVzdCsweDExLzB4MjAKWyAgMTk3LjA4MDU2N10gID8gaW50 ZWxfYXRvbWljX2NvbW1pdF90YWlsKzB4MzM0MC8weDMzNDAgW2k5MTVdClsgIDE5Ny4wODA1OTdd ICA/IGRybV9hdG9taWNfY3J0Y19zZXRfcHJvcGVydHkrMHgzMDMvMHg1ODAgW2RybV0KWyAgMTk3 LjA4MDY3NF0gID8gaW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKzB4MzM0MC8weDMzNDAgW2k5MTVd ClsgIDE5Ny4wODA3MDRdICBkcm1fYXRvbWljX2NvbW1pdCsweGQ3LzB4ZTAgW2RybV0KWyAgMTk3 LjA4MDcyMl0gIGRybV9hdG9taWNfaGVscGVyX2NydGNfc2V0X3Byb3BlcnR5KzB4ZWMvMHgxMzAg W2RybV9rbXNfaGVscGVyXQpbICAxOTcuMDgwNzQ5XSAgZHJtX21vZGVfY3J0Y19zZXRfb2JqX3By b3ArMHg3ZC8weGIwIFtkcm1dClsgIDE5Ny4wODA3NzVdICBkcm1fbW9kZV9vYmpfc2V0X3Byb3Bl cnR5X2lvY3RsKzB4NTBiLzB4NWQwIFtkcm1dClsgIDE5Ny4wODA3ODNdICA/IF9fbWlnaHRfZmF1 bHQrMHgxMDQvMHgxODAKWyAgMTk3LjA4MDgwOV0gID8gZHJtX21vZGVfb2JqX2ZpbmRfcHJvcF9p ZCsweDE2MC8weDE2MCBbZHJtXQpbICAxOTcuMDgwODM4XSAgPyBkcm1fbW9kZV9vYmpfZmluZF9w cm9wX2lkKzB4MTYwLzB4MTYwIFtkcm1dClsgIDE5Ny4wODA4NjFdICBkcm1faW9jdGxfa2VybmVs KzB4MTU0LzB4MWEwIFtkcm1dClsgIDE5Ny4wODA4ODVdICBkcm1faW9jdGwrMHg2MjQvMHg4ZjAg W2RybV0KWyAgMTk3LjA4MDkxMF0gID8gZHJtX21vZGVfb2JqX2ZpbmRfcHJvcF9pZCsweDE2MC8w eDE2MCBbZHJtXQpbICAxOTcuMDgwOTM0XSAgPyBkcm1fZ2V0dW5pcXVlKzB4MjEwLzB4MjEwIFtk cm1dClsgIDE5Ny4wODA5NDNdICA/IF9faGFuZGxlX21tX2ZhdWx0KzB4MWJkMC8weDFjZTAKWyAg MTk3LjA4MDk0OV0gID8gbG9ja19kb3duZ3JhZGUrMHg2MTAvMHg2MTAKWyAgMTk3LjA4MDk1N10g ID8gX19scnVfY2FjaGVfYWRkKzB4MTVhLzB4MTgwClsgIDE5Ny4wODA5NjddICBkb192ZnNfaW9j dGwrMHhkOTIvMHhlNDAKWyAgMTk3LjA4MDk3NV0gID8gaW9jdGxfcHJlYWxsb2NhdGUrMHgxYjAv MHgxYjAKWyAgMTk3LjA4MDk4Ml0gID8gc2VsaW51eF9jYXBhYmxlKzB4MjAvMHgyMApbICAxOTcu MDgwOTkxXSAgPyBfX2RvX3BhZ2VfZmF1bHQrMHg3YjcvMHg5YTAKWyAgMTk3LjA4MDk5N10gID8g bG9ja19kb3duZ3JhZGUrMHg1YmIvMHg2MTAKWyAgMTk3LjA4MTAwN10gID8gc2VjdXJpdHlfZmls ZV9pb2N0bCsweDU3LzB4OTAKWyAgMTk3LjA4MTAxNl0gIFN5U19pb2N0bCsweDRlLzB4ODAKWyAg MTk3LjA4MTAyNF0gIGVudHJ5X1NZU0NBTExfNjRfZmFzdHBhdGgrMHgxOC8weGFkClsgIDE5Ny4w ODEwMzBdIFJJUDogMDAzMzoweDdmNjFmMjg3YTk4NwpbICAxOTcuMDgxMDM1XSBSU1A6IDAwMmI6 MDAwMDdmZmY3ZDQ0ZDE4OCBFRkxBR1M6IDAwMDAwMjQ2IE9SSUdfUkFYOiAwMDAwMDAwMDAwMDAw MDEwClsgIDE5Ny4wODEwNDNdIFJBWDogZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDAwMDAwMDAw MDAwMDAgUkNYOiAwMDAwN2Y2MWYyODdhOTg3ClsgIDE5Ny4wODEwNDhdIFJEWDogMDAwMDdmZmY3 ZDQ0ZDFjMCBSU0k6IDAwMDAwMDAwYzAxODY0YmEgUkRJOiAwMDAwMDAwMDAwMDAwMDAzClsgIDE5 Ny4wODEwNTNdIFJCUDogMDAwMDdmNjFmMmIzZWIwMCBSMDg6IDAwMDAwMDAwMDAwMDAwNTkgUjA5 OiAwMDAwMDAwMDAwMDAwMDAwClsgIDE5Ny4wODEwNThdIFIxMDogMDAwMDAwMmVhNWM0YTI5MCBS MTE6IDAwMDAwMDAwMDAwMDAyNDYgUjEyOiAwMDAwN2Y2MWYyYjNlYjU4ClsgIDE5Ny4wODEwNjNd IFIxMzogMDAwMDAwMDAwMDAwMTAxMCBSMTQ6IDAwMDA3ZjYxZjJiM2ViNTggUjE1OiAwMDAwMDAw MDAwMDAyNzAyCgpCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxNjU5ClNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVu Lmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ClJlcG9ydGVkLWJ5OiBNYXJ0aW4gUGVyZXMgPG1h cnRpbi5wZXJlc0BsaW51eC5pbnRlbC5jb20+CkNjOiBNYXJ0aW4gUGVyZXMgPG1hcnRpbi5wZXJl c0BsaW51eC5pbnRlbC5jb20+CkZpeGVzOiA4MmNmNDM1YjMxMzQgKCJkcm0vaTkxNTogSW1wbGVt ZW50IGNvbG9yIG1hbmFnZW1lbnQgb24gYmR3L3NrbC9ieHQva2JsIikKQ2M6IFNoYXNoYW5rIFNo YXJtYSA8c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KQ2M6IEtpcmFuIFMgS3VtYXIgPGtpcmFu LnMua3VtYXJAaW50ZWwuY29tPgpDYzogS2F1c2FsIE1hbGxhZGkgPGthdXNhbG1hbGxhZGlAZ21h aWwuY29tPgpDYzogTGlvbmVsIExhbmR3ZXJsaW4gPGxpb25lbC5nLmxhbmR3ZXJsaW5AaW50ZWwu Y29tPgpDYzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KQ2M6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgpDYzogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGxpbnV4LmludGVsLmNvbT4KQ2M6IGludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKTGluazogaHR0cHM6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzIw MTcwNzI0MDkxNDMxLjI0MjUxLTEtbWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tClJl dmlld2VkLWJ5OiBMaW9uZWwgTGFuZHdlcmxpbiA8bGlvbmVsLmcubGFuZHdlcmxpbkBpbnRlbC5j b20+CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IDA5YTkyYmM4NzczYjQzMTRlMDJiNDc4ZTAw M2ZlNTkzNmNlODVhZGIpClNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBp bnRlbC5jb20+ClNpZ25lZC1vZmYtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4 Zm91bmRhdGlvbi5vcmc+CgotLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMg fCAgICAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jb2xvci5jCkBAIC0zOTQsNiArMzk0LDcgQEAgc3RhdGljIHZvaWQgYnJvYWR3ZWxsX2xvYWRf bHV0cyhzdHJ1Y3QgZAogCQl9CiAKIAkJLyogUHJvZ3JhbSB0aGUgbWF4IHJlZ2lzdGVyIHRvIGNs YW1wIHZhbHVlcyA+IDEuMC4gKi8KKwkJaSA9IGx1dF9zaXplIC0gMTsKIAkJSTkxNV9XUklURShQ UkVDX1BBTF9HQ19NQVgocGlwZSwgMCksCiAJCQkgICBkcm1fY29sb3JfbHV0X2V4dHJhY3QobHV0 W2ldLnJlZCwgMTYpKTsKIAkJSTkxNV9XUklURShQUkVDX1BBTF9HQ19NQVgocGlwZSwgMSksCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753864AbdHOBqO (ORCPT ); Mon, 14 Aug 2017 21:46:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56684 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378AbdHOBTP (ORCPT ); Mon, 14 Aug 2017 21:19:15 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maarten Lankhorst , Martin Peres , Shashank Sharma , Kiran S Kumar , Kausal Malladi , Lionel Landwerlin , Matt Roper , Daniel Vetter , Jani Nikula , intel-gfx@lists.freedesktop.org, Jani Nikula Subject: [PATCH 4.9 16/41] drm/i915: Fix out-of-bounds array access in bdw_load_gamma_lut Date: Mon, 14 Aug 2017 18:18:26 -0700 Message-Id: <20170815011809.594179167@linuxfoundation.org> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20170815011808.667221255@linuxfoundation.org> References: <20170815011808.667221255@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maarten Lankhorst commit 5279fc7724ae3a82c9cfe5b09c1fb07ff0e41056 upstream. bdw_load_gamma_lut is writing beyond the array to the maximum value. The intend of the function is to clamp values > 1 to 1, so write the intended color to the max register. This fixes the following KASAN warning: [ 197.020857] [IGT] kms_pipe_color: executing [ 197.063434] [IGT] kms_pipe_color: starting subtest ctm-0-25-pipe0 [ 197.078989] ================================================================== [ 197.079127] BUG: KASAN: slab-out-of-bounds in bdw_load_gamma_lut.isra.2+0x3b9/0x570 [i915] [ 197.079188] Read of size 2 at addr ffff8800d38db150 by task kms_pipe_color/1839 [ 197.079208] CPU: 2 PID: 1839 Comm: kms_pipe_color Tainted: G U 4.13.0-rc1-patser+ #5211 [ 197.079215] Hardware name: NUC5i7RYB, BIOS RYBDWi35.86A.0246.2015.0309.1355 03/09/2015 [ 197.079220] Call Trace: [ 197.079230] dump_stack+0x68/0x9e [ 197.079239] print_address_description+0x6f/0x250 [ 197.079251] kasan_report+0x216/0x370 [ 197.079374] ? bdw_load_gamma_lut.isra.2+0x3b9/0x570 [i915] [ 197.079451] ? gen8_write16+0x4e0/0x4e0 [i915] [ 197.079460] __asan_report_load2_noabort+0x14/0x20 [ 197.079535] bdw_load_gamma_lut.isra.2+0x3b9/0x570 [i915] [ 197.079612] broadwell_load_luts+0x1df/0x550 [i915] [ 197.079690] intel_color_load_luts+0x7b/0x80 [i915] [ 197.079764] intel_begin_crtc_commit+0x138/0x760 [i915] [ 197.079783] drm_atomic_helper_commit_planes_on_crtc+0x1a3/0x820 [drm_kms_helper] [ 197.079859] ? intel_pre_plane_update+0x571/0x580 [i915] [ 197.079937] intel_update_crtc+0x238/0x330 [i915] [ 197.080016] intel_update_crtcs+0x10f/0x210 [i915] [ 197.080092] intel_atomic_commit_tail+0x1552/0x3340 [i915] [ 197.080101] ? _raw_spin_unlock+0x3c/0x40 [ 197.080110] ? __queue_work+0xb40/0xbf0 [ 197.080188] ? skl_update_crtcs+0xc00/0xc00 [i915] [ 197.080195] ? trace_hardirqs_on+0xd/0x10 [ 197.080269] ? intel_atomic_commit_ready+0x128/0x13c [i915] [ 197.080329] ? __i915_sw_fence_complete+0x5b8/0x6d0 [i915] [ 197.080336] ? debug_object_activate+0x39e/0x580 [ 197.080397] ? i915_sw_fence_await+0x30/0x30 [i915] [ 197.080409] ? __might_sleep+0x15b/0x180 [ 197.080483] intel_atomic_commit+0x944/0xa70 [i915] [ 197.080490] ? refcount_dec_and_test+0x11/0x20 [ 197.080567] ? intel_atomic_commit_tail+0x3340/0x3340 [i915] [ 197.080597] ? drm_atomic_crtc_set_property+0x303/0x580 [drm] [ 197.080674] ? intel_atomic_commit_tail+0x3340/0x3340 [i915] [ 197.080704] drm_atomic_commit+0xd7/0xe0 [drm] [ 197.080722] drm_atomic_helper_crtc_set_property+0xec/0x130 [drm_kms_helper] [ 197.080749] drm_mode_crtc_set_obj_prop+0x7d/0xb0 [drm] [ 197.080775] drm_mode_obj_set_property_ioctl+0x50b/0x5d0 [drm] [ 197.080783] ? __might_fault+0x104/0x180 [ 197.080809] ? drm_mode_obj_find_prop_id+0x160/0x160 [drm] [ 197.080838] ? drm_mode_obj_find_prop_id+0x160/0x160 [drm] [ 197.080861] drm_ioctl_kernel+0x154/0x1a0 [drm] [ 197.080885] drm_ioctl+0x624/0x8f0 [drm] [ 197.080910] ? drm_mode_obj_find_prop_id+0x160/0x160 [drm] [ 197.080934] ? drm_getunique+0x210/0x210 [drm] [ 197.080943] ? __handle_mm_fault+0x1bd0/0x1ce0 [ 197.080949] ? lock_downgrade+0x610/0x610 [ 197.080957] ? __lru_cache_add+0x15a/0x180 [ 197.080967] do_vfs_ioctl+0xd92/0xe40 [ 197.080975] ? ioctl_preallocate+0x1b0/0x1b0 [ 197.080982] ? selinux_capable+0x20/0x20 [ 197.080991] ? __do_page_fault+0x7b7/0x9a0 [ 197.080997] ? lock_downgrade+0x5bb/0x610 [ 197.081007] ? security_file_ioctl+0x57/0x90 [ 197.081016] SyS_ioctl+0x4e/0x80 [ 197.081024] entry_SYSCALL_64_fastpath+0x18/0xad [ 197.081030] RIP: 0033:0x7f61f287a987 [ 197.081035] RSP: 002b:00007fff7d44d188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 197.081043] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f61f287a987 [ 197.081048] RDX: 00007fff7d44d1c0 RSI: 00000000c01864ba RDI: 0000000000000003 [ 197.081053] RBP: 00007f61f2b3eb00 R08: 0000000000000059 R09: 0000000000000000 [ 197.081058] R10: 0000002ea5c4a290 R11: 0000000000000246 R12: 00007f61f2b3eb58 [ 197.081063] R13: 0000000000001010 R14: 00007f61f2b3eb58 R15: 0000000000002702 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101659 Signed-off-by: Maarten Lankhorst Reported-by: Martin Peres Cc: Martin Peres Fixes: 82cf435b3134 ("drm/i915: Implement color management on bdw/skl/bxt/kbl") Cc: Shashank Sharma Cc: Kiran S Kumar Cc: Kausal Malladi Cc: Lionel Landwerlin Cc: Matt Roper Cc: Daniel Vetter Cc: Jani Nikula Cc: intel-gfx@lists.freedesktop.org Link: https://patchwork.freedesktop.org/patch/msgid/20170724091431.24251-1-maarten.lankhorst@linux.intel.com Reviewed-by: Lionel Landwerlin (cherry picked from commit 09a92bc8773b4314e02b478e003fe5936ce85adb) Signed-off-by: Jani Nikula Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/intel_color.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/i915/intel_color.c +++ b/drivers/gpu/drm/i915/intel_color.c @@ -394,6 +394,7 @@ static void broadwell_load_luts(struct d } /* Program the max register to clamp values > 1.0. */ + i = lut_size - 1; I915_WRITE(PREC_PAL_GC_MAX(pipe, 0), drm_color_lut_extract(lut[i].red, 16)); I915_WRITE(PREC_PAL_GC_MAX(pipe, 1),