From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: refactor xfs_trans_roll
Date: Tue, 15 Aug 2017 11:36:45 +1000 [thread overview]
Message-ID: <20170815013645.GD21024@dastard> (raw)
In-Reply-To: <20170813144216.11192-2-hch@lst.de>
On Sun, Aug 13, 2017 at 04:42:14PM +0200, Christoph Hellwig wrote:
> Split xfs_trans_roll into a low-level helper that just rolls the
> actual transaction and a new higher level xfs_trans_roll_inode
> that takes care of logging and rejoining the inode. This gets
> rid of the NULL inode case, and allows to simplify the special
> cases in the deferred operation code.
....
> diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
> index 2011620008de..c43e78b5c035 100644
> --- a/fs/xfs/xfs_trans.c
> +++ b/fs/xfs/xfs_trans.c
> @@ -1034,26 +1034,19 @@ xfs_trans_cancel(
> * chunk we've been working on and get a new transaction to continue.
> */
> int
> -xfs_trans_roll(
> - struct xfs_trans **tpp,
> - struct xfs_inode *dp)
> +__xfs_trans_roll(
> + struct xfs_trans **tpp)
Do we really need the "__" prefix? Seems unnecessary to me because
all the existing callers are modified...
Other than that, every else looks good.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2017-08-15 1:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 14:42 explicitly join inodes to deferred operations Christoph Hellwig
2017-08-13 14:42 ` [PATCH 1/3] xfs: refactor xfs_trans_roll Christoph Hellwig
2017-08-15 1:36 ` Dave Chinner [this message]
2017-08-13 14:42 ` [PATCH 2/3] xfs: rename xfs_defer_join to xfs_defer_join_inode Christoph Hellwig
2017-08-15 1:37 ` Dave Chinner
2017-08-16 17:21 ` Darrick J. Wong
2017-08-17 7:44 ` Christoph Hellwig
2017-08-17 16:22 ` Darrick J. Wong
2017-08-13 14:42 ` [PATCH 3/3] xfs: remove the ip argument to xfs_defer_finish Christoph Hellwig
2017-08-16 17:23 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2017-08-28 7:44 explicitly join inodes to deferred operations V2 (this time for real) Christoph Hellwig
2017-08-28 7:44 ` [PATCH 1/3] xfs: refactor xfs_trans_roll Christoph Hellwig
2017-08-28 17:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815013645.GD21024@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.