From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhRtW-00063p-59 for qemu-devel@nongnu.org; Mon, 14 Aug 2017 22:47:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhRtT-0008Bi-3o for qemu-devel@nongnu.org; Mon, 14 Aug 2017 22:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55636) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhRtS-0008BJ-Tr for qemu-devel@nongnu.org; Mon, 14 Aug 2017 22:47:47 -0400 Date: Tue, 15 Aug 2017 05:47:44 +0300 From: "Michael S. Tsirkin" Message-ID: <20170815054627-mutt-send-email-mst@kernel.org> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> <20170814145550.GA1475@perard.uk.xensource.com> <20170814185150-mutt-send-email-mst@kernel.org> <20170814164502.GB1475@perard.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170814164502.GB1475@perard.uk.xensource.com> Subject: Re: [Qemu-devel] [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Bruce Rogers , Igor Mammedov , Paolo Bonzini , Richard Henderson , Eduardo Habkost On Mon, Aug 14, 2017 at 05:45:02PM +0100, Anthony PERARD wrote: > On Mon, Aug 14, 2017 at 06:53:14PM +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 14, 2017 at 03:55:50PM +0100, Anthony PERARD wrote: > > > On Fri, Aug 11, 2017 at 08:18:28PM +0300, Michael S. Tsirkin wrote: > > > > On Fri, Aug 11, 2017 at 04:11:37PM +0100, Anthony PERARD wrote: > > > > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > > > > set, but this was done only when ACPI tables are built which is not > > > > > needed for a Xen guest. The need for the property starts with commit > > > > > "pc: pcihp: avoid adding ACPI_PCIHP_PROP_BSEL twice" > > > > > (f0c9d64a68b776374ec4732424a3e27753ce37b6). > > > > > > > > > > Set pci info before checking for the needs to build ACPI tables. > > > > > > > > > > Reported-by: Sander Eikelenboom > > > > > Tested-by: Sander Eikelenboom > > > > > Signed-off-by: Anthony PERARD > > > > > > > > I am worried that Xen will come to depend on specific > > > > assignment of bsel which isn't guaranteed. Thoughts on > > > > how to avoid that? > > > > > > Is it possible to have a different BSEL than 0 with PIIX ? > > > > With PCI to PCI bridges, yes. > > > > > Also, I don't known if having more than on PCI bus is going to work on > > > Xen, there is nothing in our ACPI tables beyond _SB.PCI0, and nothing to > > > use a different BSEL. > > > > My worry is someone might decide to implement hotplug for pci to pci > > bridges on Xen. If doing that, it's important to use the qemu supplied > > acpi tables. > > I can always add assert((xen_enable() && !bsel) || !xen_enable()) in > acpi_set_bsel(), so if someone was going to make any change, he would > find out about bsel quicker. But I don't see Xen using QEMU supplied > ACPI tables anytime soon. In that case I'd prefer assigning bsel 0 just for the root bus on xen. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH for-2.10 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed Date: Tue, 15 Aug 2017 05:47:44 +0300 Message-ID: <20170815054627-mutt-send-email-mst@kernel.org> References: <20170811151138.29405-1-anthony.perard@citrix.com> <20170811151138.29405-2-anthony.perard@citrix.com> <20170811201006-mutt-send-email-mst@kernel.org> <20170814145550.GA1475@perard.uk.xensource.com> <20170814185150-mutt-send-email-mst@kernel.org> <20170814164502.GB1475@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhRtV-0001IJ-5l for xen-devel@lists.xenproject.org; Tue, 15 Aug 2017 02:47:49 +0000 Content-Disposition: inline In-Reply-To: <20170814164502.GB1475@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: Stefano Stabellini , Eduardo Habkost , qemu-devel@nongnu.org, Bruce Rogers , Paolo Bonzini , Igor Mammedov , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBBdWcgMTQsIDIwMTcgYXQgMDU6NDU6MDJQTSArMDEwMCwgQW50aG9ueSBQRVJBUkQg d3JvdGU6Cj4gT24gTW9uLCBBdWcgMTQsIDIwMTcgYXQgMDY6NTM6MTRQTSArMDMwMCwgTWljaGFl bCBTLiBUc2lya2luIHdyb3RlOgo+ID4gT24gTW9uLCBBdWcgMTQsIDIwMTcgYXQgMDM6NTU6NTBQ TSArMDEwMCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6Cj4gPiA+IE9uIEZyaSwgQXVnIDExLCAyMDE3 IGF0IDA4OjE4OjI4UE0gKzAzMDAsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+ID4gPiBP biBGcmksIEF1ZyAxMSwgMjAxNyBhdCAwNDoxMTozN1BNICswMTAwLCBBbnRob255IFBFUkFSRCB3 cm90ZToKPiA+ID4gPiA+IFRvIGRvIFBDSSBwYXNzdGhyb3VnaCB3aXRoIFhlbiwgdGhlIHByb3Bl cnR5IGFjcGktcGNpaHAtYnNlbCBuZWVkcyB0byBiZQo+ID4gPiA+ID4gc2V0LCBidXQgdGhpcyB3 YXMgZG9uZSBvbmx5IHdoZW4gQUNQSSB0YWJsZXMgYXJlIGJ1aWx0IHdoaWNoIGlzIG5vdAo+ID4g PiA+ID4gbmVlZGVkIGZvciBhIFhlbiBndWVzdC4gVGhlIG5lZWQgZm9yIHRoZSBwcm9wZXJ0eSBz dGFydHMgd2l0aCBjb21taXQKPiA+ID4gPiA+ICJwYzogcGNpaHA6IGF2b2lkIGFkZGluZyBBQ1BJ X1BDSUhQX1BST1BfQlNFTCB0d2ljZSIKPiA+ID4gPiA+IChmMGM5ZDY0YTY4Yjc3NjM3NGVjNDcz MjQyNGEzZTI3NzUzY2UzN2I2KS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gU2V0IHBjaSBpbmZvIGJl Zm9yZSBjaGVja2luZyBmb3IgdGhlIG5lZWRzIHRvIGJ1aWxkIEFDUEkgdGFibGVzLgo+ID4gPiA+ ID4gCj4gPiA+ID4gPiBSZXBvcnRlZC1ieTogU2FuZGVyIEVpa2VsZW5ib29tIDxsaW51eEBlaWtl bGVuYm9vbS5pdD4KPiA+ID4gPiA+IFRlc3RlZC1ieTogU2FuZGVyIEVpa2VsZW5ib29tIDxsaW51 eEBlaWtlbGVuYm9vbS5pdD4KPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJE IDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgo+ID4gPiA+IAo+ID4gPiA+IEkgYW0gd29ycmll ZCB0aGF0IFhlbiB3aWxsIGNvbWUgdG8gZGVwZW5kIG9uIHNwZWNpZmljCj4gPiA+ID4gYXNzaWdu bWVudCBvZiBic2VsIHdoaWNoIGlzbid0IGd1YXJhbnRlZWQuIFRob3VnaHRzIG9uCj4gPiA+ID4g aG93IHRvIGF2b2lkIHRoYXQ/Cj4gPiA+IAo+ID4gPiBJcyBpdCBwb3NzaWJsZSB0byBoYXZlIGEg ZGlmZmVyZW50IEJTRUwgdGhhbiAwIHdpdGggUElJWCA/Cj4gPiAKPiA+IFdpdGggUENJIHRvIFBD SSBicmlkZ2VzLCB5ZXMuCj4gPiAKPiA+ID4gQWxzbywgSSBkb24ndCBrbm93biBpZiBoYXZpbmcg bW9yZSB0aGFuIG9uIFBDSSBidXMgaXMgZ29pbmcgdG8gd29yayBvbgo+ID4gPiBYZW4sIHRoZXJl IGlzIG5vdGhpbmcgaW4gb3VyIEFDUEkgdGFibGVzIGJleW9uZCBfU0IuUENJMCwgYW5kIG5vdGhp bmcgdG8KPiA+ID4gdXNlIGEgZGlmZmVyZW50IEJTRUwuCj4gPiAKPiA+IE15IHdvcnJ5IGlzIHNv bWVvbmUgbWlnaHQgZGVjaWRlIHRvIGltcGxlbWVudCBob3RwbHVnIGZvciBwY2kgdG8gcGNpCj4g PiBicmlkZ2VzIG9uIFhlbi4gSWYgZG9pbmcgdGhhdCwgaXQncyBpbXBvcnRhbnQgdG8gdXNlIHRo ZSBxZW11IHN1cHBsaWVkCj4gPiBhY3BpIHRhYmxlcy4KPiAKPiBJIGNhbiBhbHdheXMgYWRkIGFz c2VydCgoeGVuX2VuYWJsZSgpICYmICFic2VsKSB8fCAheGVuX2VuYWJsZSgpKSBpbgo+IGFjcGlf c2V0X2JzZWwoKSwgc28gaWYgc29tZW9uZSB3YXMgZ29pbmcgdG8gbWFrZSBhbnkgY2hhbmdlLCBo ZSB3b3VsZAo+IGZpbmQgb3V0IGFib3V0IGJzZWwgcXVpY2tlci4gQnV0IEkgZG9uJ3Qgc2VlIFhl biB1c2luZyBRRU1VIHN1cHBsaWVkCj4gQUNQSSB0YWJsZXMgYW55dGltZSBzb29uLgoKSW4gdGhh dCBjYXNlIEknZCBwcmVmZXIgYXNzaWduaW5nIGJzZWwgMCBqdXN0IGZvciB0aGUgcm9vdCBidXMg b24geGVuLgoKLS0gCk1TVAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==