From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752659AbdHOJIE (ORCPT ); Tue, 15 Aug 2017 05:08:04 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:35429 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbdHOJID (ORCPT ); Tue, 15 Aug 2017 05:08:03 -0400 From: Bartosz Golaszewski To: Thomas Gleixner , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2] irq_work: improve the flag definitions Date: Tue, 15 Aug 2017 11:07:59 +0200 Message-Id: <20170815090759.7432-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY. While we're at it: use the BIT() macro for all flags. Signed-off-by: Bartosz Golaszewski --- v1 -> v2: - IRQ_WORK_LAZY is defined to 4UL which is BIT(2) not BIT(3) include/linux/irq_work.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h index 47b9ebd4a74f..71e4bcdff2ce 100644 --- a/include/linux/irq_work.h +++ b/include/linux/irq_work.h @@ -12,10 +12,10 @@ * busy NULL, 2 -> {free, claimed} : callback in progress, can be claimed */ -#define IRQ_WORK_PENDING 1UL -#define IRQ_WORK_BUSY 2UL -#define IRQ_WORK_FLAGS 3UL -#define IRQ_WORK_LAZY 4UL /* Doesn't want IPI, wait for tick */ +#define IRQ_WORK_PENDING BIT(0) +#define IRQ_WORK_BUSY BIT(1) +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY) +#define IRQ_WORK_LAZY BIT(2) /* Doesn't want IPI, wait for tick */ struct irq_work { unsigned long flags; -- 2.13.2