From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: schwidefsky@de.ibm.com, sth@linux.vnet.ibm.com,
hoeppner@linux.vnet.ibm.com, jwi@linux.vnet.ibm.com,
ubraun@linux.vnet.ibm.com, maier@linux.vnet.ibm.com,
cohuck@redhat.com, pasic@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [RFT 00/13] constify s390 ccw_device_id
Date: Tue, 15 Aug 2017 13:30:44 +0200 [thread overview]
Message-ID: <20170815113044.GC3552@osiris> (raw)
In-Reply-To: <1502793344-5368-1-git-send-email-arvind.yadav.cs@gmail.com>
On Tue, Aug 15, 2017 at 04:05:31PM +0530, Arvind Yadav wrote:
> ccw_device_id are not supposed to change at runtime. All functions
> working with ccw_device_id provided by <asm/ccwdev.h> work with
> const ccw_device_id. So mark ccw_device_id member of struct ccw driver
> as const. And change all driver relatively.
>
> Arvind Yadav (13):
> [RFT 01/13] s390: ccwdev: constify ccw_device_id
> [RFT 02/13] s390: dasd_eckd: constify ccw_device_id
> [RFT 03/13] s390: dasd_fba: constify ccw_device_id
> [RFT 04/13] s390: con3215: constify ccw_device_id
> [RFT 05/13] s390: raw3270: constify ccw_device_id
> [RFT 06/13] s390: tape_34xx: constify ccw_device_id
> [RFT 07/13] s390: tape_3590: constify ccw_device_id
> [RFT 08/13] s390: vmur: constify ccw_device_id
> [RFT 09/13] s390: ctcm: constify ccw_device_id
> [RFT 10/13] s390: lcs: constify ccw_device_id
> [RFT 11/13] s390: qeth: constify ccw_device_id
> [RFT 12/13] s390: zfcp: constify ccw_device_id
> [RFT 13/13] s390: virtio: constify ccw_device_id
Did the constify work reveal a single bug until now? This causes a lot of
code churn, and I'm failing to see an added value here.
In addition this is not worth splitting it into 13(!) patches.
prev parent reply other threads:[~2017-08-15 11:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 10:35 [RFT 00/13] constify s390 ccw_device_id Arvind Yadav
2017-08-15 10:35 ` [RFT 01/13] s390: ccwdev: constify ccw_device_id Arvind Yadav
2017-08-15 10:35 ` [RFT 02/13] s390: dasd_eckd: " Arvind Yadav
2017-08-15 10:35 ` [RFT 03/13] s390: dasd_fba: " Arvind Yadav
2017-08-15 10:35 ` [RFT 04/13] s390: con3215: " Arvind Yadav
2017-08-15 10:35 ` [RFT 05/13] s390: raw3270: " Arvind Yadav
2017-08-15 10:35 ` [RFT 06/13] s390: tape_34xx: " Arvind Yadav
2017-08-15 10:35 ` [RFT 07/13] s390: tape_3590: " Arvind Yadav
2017-08-15 10:35 ` [RFT 08/13] s390: vmur: " Arvind Yadav
2017-08-15 10:35 ` [RFT 09/13] s390: ctcm: " Arvind Yadav
2017-08-15 10:35 ` [RFT 10/13] s390: lcs: " Arvind Yadav
2017-08-15 10:35 ` [RFT 11/13] s390: qeth: " Arvind Yadav
2017-08-15 10:35 ` [RFT 12/13] s390: zfcp: " Arvind Yadav
2017-08-15 10:35 ` [RFT 13/13] s390: virtio: " Arvind Yadav
2017-08-15 11:11 ` Cornelia Huck
2017-08-15 11:30 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815113044.GC3552@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=cohuck@redhat.com \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=jwi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sth@linux.vnet.ibm.com \
--cc=ubraun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.