Re: [nft PATCH 1/4] mnl: Drop --echo support for non-batch calls

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Aug 15, 2017 at 01:05:04PM +0200, Phil Sutter wrote:
> Hi,
> 
> On Tue, Aug 15, 2017 at 12:25:00PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Aug 15, 2017 at 01:43:02AM +0200, Phil Sutter wrote:
> [...]
> > > I didn't notice this because I didn't test for kernels without support
> > > for transactions. This has been added to nftables in kernel version 3.16
> > > back in 2014. Since then, user space which doesn't support it can't even
> > > add a table anymore. So adding this new feature to the old code path is
> > > really not feasible, therefore drop this broken attempt at supporting
> > > it.
> > 
> > We fixed this problem with nft and 3.16 IIRC. So at least the very
> > basic featureset still available there works fine.
> 
> I was speaking of the other way around, namely old user space with
> kernel >= 3.16 (that's what I simulated by forcing batch_supported to
> false).
> 
> Given that kernel user API isn't completely compatible, do you see a
> chance to drop the non-batch code from user space at some point?

Yes, as soon as 3.16 becomes unsupported we can let that code sink I
would suggest.