From: Miroslav Lichvar <mlichvar@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning
Date: Tue, 15 Aug 2017 14:11:20 +0200 [thread overview]
Message-ID: <20170815121120.GB8800@localhost> (raw)
In-Reply-To: <1502744496-17863-2-git-send-email-john.stultz@linaro.org>
On Mon, Aug 14, 2017 at 02:01:36PM -0700, John Stultz wrote:
> Fixes the following build warning:
> freq-step.c: In function ‘main’:
> freq-step.c:271:1: warning: control reaches end of non-void function [-Wreturn-type]
> @@ -268,4 +268,6 @@ int main(int argc, char **argv)
> ksft_exit_fail();
>
> ksft_exit_pass();
> +
> + return 0;
> }
It seems most tests use "return ksft_exit_pass();". Would that be
preferred over separate return? I don't have a preference.
Both patches in this set look good to me.
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2017-08-15 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 21:01 [RFC][PATCH 1/2] kselftests: timers: freq-step: Define ADJ_SETOFFSET if device has older kernel headers John Stultz
2017-08-14 21:01 ` [RFC][PATCH 2/2] selftests: timers: freq-step: Fix build warning John Stultz
2017-08-15 12:11 ` Miroslav Lichvar [this message]
2017-08-16 23:01 ` Shuah Khan
2017-08-16 23:10 ` John Stultz
2017-08-17 3:31 ` John Stultz
2017-08-17 3:53 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170815121120.GB8800@localhost \
--to=mlichvar@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.