All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, mlindner@marvell.com
Subject: Re: [PATCH net-next 0/4] various sizeof cleanups
Date: Tue, 15 Aug 2017 22:47:50 +0300	[thread overview]
Message-ID: <20170815224731-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20170815172919.26153-1-sthemmin@microsoft.com>

On Tue, Aug 15, 2017 at 10:29:15AM -0700, Stephen Hemminger wrote:
> Noticed some places that were using sizeof as an operator.
> This is legal C but is not the convention used in the kernel.
> 
> Stephen Hemminger (4):
>   tun/tap: use paren's with sizeof
>   virtio: put paren around sizeof
>   skge: add paren around sizeof arg
>   mlx4: sizeof style usage

for tun and virtio:

Acked-by: Michael S. Tsirkin <mst@redhat.com>

>  drivers/net/ethernet/marvell/skge.c                |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/alloc.c         |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/cmd.c           |  4 ++--
>  drivers/net/ethernet/mellanox/mlx4/en_resources.c  |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/en_rx.c         |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/en_tx.c         |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/eq.c            | 20 +++++++++---------
>  drivers/net/ethernet/mellanox/mlx4/fw.c            |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/icm.c           |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/icm.h           |  4 ++--
>  drivers/net/ethernet/mellanox/mlx4/intf.c          |  2 +-
>  drivers/net/ethernet/mellanox/mlx4/main.c          | 12 +++++------
>  drivers/net/ethernet/mellanox/mlx4/mcg.c           | 12 +++++------
>  drivers/net/ethernet/mellanox/mlx4/mr.c            | 10 ++++-----
>  drivers/net/ethernet/mellanox/mlx4/qp.c            | 12 +++++------
>  .../net/ethernet/mellanox/mlx4/resource_tracker.c  | 24 +++++++++++-----------
>  drivers/net/tap.c                                  |  2 +-
>  drivers/net/tun.c                                  |  2 +-
>  drivers/net/virtio_net.c                           |  2 +-
>  19 files changed, 60 insertions(+), 60 deletions(-)
> 
> -- 
> 2.11.0

  parent reply	other threads:[~2017-08-15 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 17:29 [PATCH net-next 0/4] various sizeof cleanups Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 1/4] tun/tap: use paren's with sizeof Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 2/4] virtio: put paren around sizeof Stephen Hemminger
2017-08-15 17:29 ` Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 3/4] skge: add paren around sizeof arg Stephen Hemminger
2017-08-15 17:29 ` Stephen Hemminger
2017-08-15 17:29 ` [PATCH net-next 4/4] mlx4: sizeof style usage Stephen Hemminger
2017-08-15 18:13   ` Leon Romanovsky
     [not found]   ` <20170815172919.26153-5-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2017-08-15 18:13     ` Leon Romanovsky
2017-08-20 10:27   ` Tariq Toukan
2017-08-20 18:00     ` Stephen Hemminger via Virtualization
2017-08-20 18:00     ` Stephen Hemminger
2017-08-21 10:53       ` Tariq Toukan
     [not found]       ` <DM2PR21MB0074E2B2C697B1300B77EFEACC860-B2pw06WL+/BdZnmuHZ3GOs1VXTxX1y3OvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-21 10:53         ` Tariq Toukan
2017-08-20 10:27   ` Tariq Toukan
2017-08-15 17:29 ` Stephen Hemminger
2017-08-15 19:47 ` Michael S. Tsirkin [this message]
2017-08-16 18:02 ` [PATCH net-next 0/4] various sizeof cleanups David Miller
     [not found] ` <20170815172919.26153-1-sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>
2017-08-16 18:02   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815224731-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.