All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: Test infinite loop while searching for a free inode slot
Date: Wed, 16 Aug 2017 15:31:59 +0800	[thread overview]
Message-ID: <20170816073159.GL14807@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170816070214.GJ14807@eguan.usersys.redhat.com>

On Wed, Aug 16, 2017 at 03:02:14PM +0800, Eryu Guan wrote:
> > +
> > +_scratch_unmount
> > +
> > +# agi->freecount is 0 here, corrupt it to show extra free inodes
> > +$XFS_DB_PROG -x -c "agi 0" -c "write -d freecount 10" $SCRATCH_DEV >/dev/null 2>&1
> 
> redirect stdout and stderr to $seqres.full for debug purpose

And you can use _scratch_xfs_db wrapper instead of open coded xfs_db
command.

And I found that "write -d" failed on a crc=0 XFS, though "write -c"
allows corrupted data and bad CRC, but touch couldn't reproduce the hang
in this case, because kernel detected bad crc first and aborted inode
creation.

I think we can force a CRC enabled XFS by

_scratch_mkfs -m crc=1,finobt=0 >>$seqres.full 2>&1

Thanks,
Eryu

  reply	other threads:[~2017-08-16  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 12:55 [PATCH] xfs: Test infinite loop while searching for a free inode slot Carlos Maiolino
2017-08-16  7:02 ` Eryu Guan
2017-08-16  7:31   ` Eryu Guan [this message]
2017-08-16 15:53     ` Darrick J. Wong
2017-08-17  3:19       ` Eryu Guan
2017-08-17  8:38   ` Carlos Maiolino
2017-08-17  8:52   ` Carlos Maiolino
2017-08-17  9:19     ` Eryu Guan
2017-08-17  9:33       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170816073159.GL14807@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=cmaiolino@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.