From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Fabien DESSENNE <fabien.dessenne@st.com>
Cc: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] crypto: engine - find request type with cra_type
Date: Wed, 16 Aug 2017 10:58:15 +0200 [thread overview]
Message-ID: <20170816085815.GA5732@Red> (raw)
In-Reply-To: <f2185b14d944433c9737cabc32e3cef9@SFHDAG5NODE3.st.com>
On Tue, Aug 15, 2017 at 07:51:14AM +0000, Fabien DESSENNE wrote:
> Hi Corentin,
>
> Since I have just sent a patch to add the support of "aead_request" to crypto engine, I am wondering if your proposed change (checking cra_type instead of crypto_tfm_alg_type) and mine are compatible.
> It looks like they are (assuming we export crypto_aead_type): can you confirm?
> BR
>
> Fabien.
>
Hello
My change is incompatible with yours since I remove a switch(crypto_tfm_alg_type) that you use.
Anyway you will need my change:) because you use ablkcipher which is obsolete and you need to convert to skcipher.
regards
Corentin Labbe
next prev parent reply other threads:[~2017-08-16 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 13:17 [PATCH 0/3 v3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe
2017-08-14 13:17 ` [PATCH 1/3] crypto: skcipher - export crypto_skcipher_type2 Corentin Labbe
2017-08-14 13:17 ` [PATCH 2/3] crypto: engine - find request type with cra_type Corentin Labbe
2017-08-15 7:51 ` Fabien DESSENNE
2017-08-16 8:58 ` Corentin Labbe [this message]
2017-08-18 8:28 ` Herbert Xu
2017-08-18 11:40 ` Corentin Labbe
2017-08-14 13:17 ` [PATCH 3/3] crypto: engine - Permit to enqueue skcipher request Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816085815.GA5732@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=fabien.dessenne@st.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.