From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] whois: fix build with NLS disabled
Date: Wed, 16 Aug 2017 10:39:02 +0200 [thread overview]
Message-ID: <20170816103902.0b889b11@windsurf> (raw)
In-Reply-To: <20170816034027.flnapeznknwvkllk@tarshish>
Hello,
On Wed, 16 Aug 2017 06:40:27 +0300, Baruch Siach wrote:
> Hi Thomas, all,
>
> On Tue, Aug 15, 2017 at 10:14:40PM +0300, Baruch Siach wrote:
> > whois build uses the xgettext utility to build translation files.
> > This utility may not be available when NLS is disabled. Add a patch that
> > allows skipping the generation of translation files. Use that to skip
> > the translation when NLS is disabled.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/862/862d8165a59711c970c65d90009a527315a1a6b4/
> > http://autobuild.buildroot.net/results/b62/b62ec9d6f350e409731d47ffb585344c516944e8/
> > http://autobuild.buildroot.net/results/be2/be28d06ae004a46c87133d6f07709c6f909288d8/
> >
> > Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > v2: patch to add HAVE_GETTEXT that allows disable for gettext (Thomas P)
>
> Upstream rejected[1] the patch, basically suggesting the approach of v1[2],
> that is, make only the targets we want while omitting the gettext targets. So
> we can either carry this patch forever, or apply [2].
OK, fair enough, let's take your original PATCH 1/3. Thanks for pushing
this further anyway!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-08-16 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 19:14 [Buildroot] [PATCH v2 1/2] whois: fix build with NLS disabled Baruch Siach
2017-08-15 19:14 ` [Buildroot] [PATCH v2 2/2] whois: use github repo as home page Baruch Siach
2017-08-16 21:10 ` Thomas Petazzoni
2017-08-16 3:40 ` [Buildroot] [PATCH v2 1/2] whois: fix build with NLS disabled Baruch Siach
2017-08-16 8:39 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816103902.0b889b11@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.