From: Jisheng Zhang <jszhang@marvell.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
Zhoujie Wu <zjwu@marvell.com>,
hannah@marvell.com
Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org,
adrian.hunter@intel.com, zmxu@marvell.com, nadavh@marvell.com,
xigu@marvell.com, dingwei@marvell.com, kostap@marvell.com,
hongd@marvell.com, dougj@marvell.com, ygao@marvell.com,
liuw@marvell.com, gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com
Subject: Re: [EXT] Re: [PATCH] mmc: sdhci-xenon: add gpio hard reset support
Date: Wed, 16 Aug 2017 10:44:29 +0800 [thread overview]
Message-ID: <20170816104429.00c35ca9@xhacker> (raw)
In-Reply-To: <b56fc3b4-4fff-0881-2233-8f26a6c8407a@rock-chips.com>
On Wed, 16 Aug 2017 08:32:09 +0800 Shawn Lin wrote:
> Hi
>
> On 2017/8/16 6:40, Zhoujie Wu wrote:
> > Hi Shawn,
>
> >> ----------------------------------------------------------------------
> >> Hi
> >>
> >> On 2017/8/15 6:19, Zhoujie Wu wrote:
> >>> On some platforms, like armada3700, SD card need to
> >>> do hard reset by gpio toggling to make it work properly
> >>> after warm reset the board.
> >>
> >> I don't get this that SD card need to do hard reset...
> >>
> >> I assume what you talk about is either for eMMC or a power-cycle
> >> for SD card.
> >
> > The subject of the patch confused you. What I want is a power-cycle for
> > the SD card. The gpio is used to enable/disable the vdd power supply
> > for sd card.
> > Actually on a3700, when warm reset the board, their is no power-cycle
> > for SD card, which will lead sd card can't response correct ocr and
> > never set S18A unless a power-cycle.
> > This is the purpose I submit this patch.
> >
>
> Well, if that is the case, I suggest you to use regulator-gpio.
Oh yes! If the gpio is for power, why not make use of regulator? then
except the dts, we don't need do anything.
next prev parent reply other threads:[~2017-08-16 2:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 22:19 [PATCH] mmc: sdhci-xenon: add gpio hard reset support Zhoujie Wu
2017-08-15 2:11 ` Shawn Lin
2017-08-15 22:40 ` [EXT] " Zhoujie Wu
2017-08-15 23:27 ` Zhoujie Wu
2017-08-16 0:32 ` Shawn Lin
2017-08-16 2:44 ` Jisheng Zhang [this message]
2017-08-16 22:46 ` Zhoujie Wu
2017-08-17 0:47 ` Shawn Lin
2017-08-17 18:34 ` Zhoujie Wu
2017-08-15 2:56 ` Jisheng Zhang
2017-08-15 22:43 ` Zhoujie Wu
2017-08-16 2:22 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816104429.00c35ca9@xhacker \
--to=jszhang@marvell.com \
--cc=adrian.hunter@intel.com \
--cc=dingwei@marvell.com \
--cc=dougj@marvell.com \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=hongd@marvell.com \
--cc=kostap@marvell.com \
--cc=linux-mmc@vger.kernel.org \
--cc=liuw@marvell.com \
--cc=nadavh@marvell.com \
--cc=shawn.lin@rock-chips.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
--cc=ygao@marvell.com \
--cc=zjwu@marvell.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.