From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Robin van der Gracht <robin@protonic.nl>
Cc: linux-kernel@vger.kernel.org,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: Use generic device properties function
Date: Wed, 16 Aug 2017 11:32:40 -0700 [thread overview]
Message-ID: <20170816183240.GB25491@dtor-ws> (raw)
In-Reply-To: <20170816102248.25498-1-robin@protonic.nl>
On Wed, Aug 16, 2017 at 12:22:48PM +0200, Robin van der Gracht wrote:
> matrix_keypad_parse_of_params() was replaced early this year.
>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
>
> Early this year Dmitry Torokhov introduced a switch to using generic
> device properties instead of being OF-specific.
>
> Somehow this driver wasn't included in the update.
It was outside of "input" tree so I did not update directly, so I kept
the old name available. I meant to send a separate patch updating
ht16k33, but I guess I forgot...
FWIW Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
I think you want to send it to GregKH as he was picking up the other
ht16k33 patches.
>
> For reference: https://patchwork.kernel.org/patch/9527095/
>
> drivers/auxdisplay/ht16k33.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index fbfa5b4cc567..99ce9731fc9c 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -354,7 +354,7 @@ static int ht16k33_keypad_probe(struct i2c_client *client,
> return err;
> }
>
> - err = matrix_keypad_parse_of_params(&client->dev, &rows, &cols);
> + err = matrix_keypad_parse_properties(&client->dev, &rows, &cols);
> if (err)
> return err;
> if (rows > HT16K33_MATRIX_KEYPAD_MAX_ROWS ||
> --
> 2.11.0
>
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-08-16 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 10:22 [PATCH] auxdisplay: ht16k33: Use generic device properties function Robin van der Gracht
2017-08-16 18:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816183240.GB25491@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.