From: Eric Leblond <eric@regit.org>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, Eric Leblond <eric@regit.org>
Subject: [nft PATH 12/16] libnftables: transaction support
Date: Wed, 16 Aug 2017 22:43:06 +0200 [thread overview]
Message-ID: <20170816204310.3371-13-eric@regit.org> (raw)
In-Reply-To: <20170816204310.3371-1-eric@regit.org>
Add batch support for libnftables. This patch
provides a set of function to handle batch command.
The cinematic is the following:
* nft_batch_start to allocate the batch structure
* multiple call to nft_batch_add
* nft_batch_commit to do the commit to kernel
* nft_batch_free to free the batch
Signed-off-by: Eric Leblond <eric@regit.org>
---
include/netlink.h | 5 +++
include/nftables/nftables.h | 7 ++++
src/libnftables.c | 89 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 101 insertions(+)
diff --git a/include/netlink.h b/include/netlink.h
index 0e1d26b..b7f87c0 100644
--- a/include/netlink.h
+++ b/include/netlink.h
@@ -54,6 +54,11 @@ struct netlink_ctx {
struct nft_cache *cache;
};
+struct nft_batch {
+ struct netlink_ctx nl_ctx;
+ struct nftnl_batch *batch;
+};
+
extern struct nftnl_table *alloc_nftnl_table(const struct handle *h);
extern struct nftnl_chain *alloc_nftnl_chain(const struct handle *h);
extern struct nftnl_rule *alloc_nftnl_rule(const struct handle *h);
diff --git a/include/nftables/nftables.h b/include/nftables/nftables.h
index 935d0db..2ddb38a 100644
--- a/include/nftables/nftables.h
+++ b/include/nftables/nftables.h
@@ -34,4 +34,11 @@ int nft_run_command_from_buffer(struct nft_ctx *nft,
char *buf, size_t buflen);
int nft_run_command_from_filename(struct nft_ctx *nft, const char *filename);
+
+struct nft_batch *nft_batch_start(struct nft_ctx *ctx);
+int nft_batch_add(struct nft_ctx *ctx, struct nft_batch *batch,
+ const char * buf, size_t buflen);
+int nft_batch_commit(struct nft_ctx *ctx, struct nft_batch *batch);
+void nft_batch_free(struct nft_batch *batch);
+
#endif
diff --git a/src/libnftables.c b/src/libnftables.c
index 494ff57..08050e5 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -151,3 +151,92 @@ int nft_run_command_from_filename(struct nft_ctx *nft, const char *filename)
erec_print_list(stderr, &msgs);
return rc;
}
+
+struct nft_batch *nft_batch_start(struct nft_ctx *nft)
+{
+ struct nft_batch *batch = malloc(sizeof(*batch));
+ if (batch == NULL)
+ return NULL;
+
+ batch->batch = mnl_batch_init();
+ mnl_batch_begin(batch->batch, mnl_seqnum_alloc(&nft->cache.seqnum));
+
+ return batch;
+}
+
+int nft_batch_add(struct nft_ctx *nft, struct nft_batch *batch,
+ const char * buf, size_t buflen)
+{
+ int rc = NFT_EXIT_SUCCESS;
+ int ret = 0;
+ struct parser_state state;
+ LIST_HEAD(msgs);
+ void *scanner;
+ struct cmd *cmd, *next;
+ struct netlink_ctx *ctx = &batch->nl_ctx;
+ uint32_t seqnum;
+ bool batch_supported = netlink_batch_supported(nft->nf_sock, &seqnum);
+
+ parser_init(nft->nf_sock, &nft->cache, &state, &msgs);
+ scanner = scanner_init(&state);
+ scanner_push_buffer(scanner, &indesc_cmdline, buf);
+
+ ret = nft_parse(scanner, &state);
+ if (ret != 0 || state.nerrs > 0) {
+ rc = -1;
+ goto err1;
+ }
+
+ list_for_each_entry(cmd, &state.cmds, list) {
+ nft_cmd_expand(cmd);
+ memset(ctx, 0, sizeof(*ctx));
+ ctx->msgs = &msgs;
+ ctx->seqnum = cmd->seqnum = mnl_seqnum_alloc(&seqnum);
+ ctx->batch = batch->batch;
+ ctx->batch_supported = batch_supported;
+ ctx->octx = &nft->output;
+ ctx->nf_sock = nft->nf_sock;
+ ctx->cache = &nft->cache;
+ init_list_head(&ctx->list);
+ ret = do_command(ctx, cmd);
+ if (ret < 0)
+ return -1;
+ }
+
+ list_for_each_entry_safe(cmd, next, &state.cmds, list) {
+ list_del(&cmd->list);
+ cmd_free(cmd);
+ }
+err1:
+ scanner_destroy(scanner);
+ erec_print_list(stderr, &msgs);
+ return rc;
+}
+
+int nft_batch_commit(struct nft_ctx *nft, struct nft_batch *batch)
+{
+ int ret = 0;
+
+ mnl_batch_end(batch->batch, mnl_seqnum_alloc(&nft->cache.seqnum));
+ LIST_HEAD(err_list);
+
+ if (!mnl_batch_ready(batch->batch))
+ goto out;
+
+ batch->nl_ctx.batch = batch->batch;
+ if (!mnl_batch_ready(batch->batch))
+ goto out;
+
+ ret = netlink_batch_send(&batch->nl_ctx, &err_list);
+out:
+ return ret;
+
+}
+
+void nft_batch_free(struct nft_batch *batch)
+{
+ if (batch == NULL)
+ return;
+ mnl_batch_reset(batch->batch);
+ xfree(batch);
+}
--
2.14.1
next prev parent reply other threads:[~2017-08-16 21:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 20:42 [nft PATCH 0/16] introduce libnftables Eric Leblond
2017-08-16 20:42 ` [nft PATH 01/16] libnftables: introduce library Eric Leblond
2017-08-17 8:57 ` Phil Sutter
2017-08-17 17:09 ` Eric Leblond
2017-08-17 17:13 ` Phil Sutter
2017-08-19 8:43 ` Eric Leblond
2017-08-19 19:07 ` Jan Engelhardt
2017-08-21 8:19 ` Pablo Neira Ayuso
2017-08-16 20:42 ` [nft PATH 02/16] libnftables: add context new and free Eric Leblond
2017-08-17 9:04 ` Phil Sutter
2017-08-16 20:42 ` [nft PATH 03/16] libnftables: add nft_run_command_from_buffer Eric Leblond
2017-08-17 9:21 ` Phil Sutter
2017-08-16 20:42 ` [nft PATH 04/16] libnftables: add nft_run_command_from_filename Eric Leblond
2017-08-16 20:42 ` [nft PATH 05/16] libnftables: put nft_run in library Eric Leblond
2017-08-16 20:43 ` [nft PATH 06/16] libnftables: add missing variable to library Eric Leblond
2017-08-17 9:35 ` Phil Sutter
2017-08-19 11:02 ` Eric Leblond
2017-08-16 20:43 ` [nft PATH 07/16] libnftables: add NFT_EXIT_* " Eric Leblond
2017-08-16 20:43 ` [nft PATH 08/16] libnftables: add a nft_cache to nft_ctx Eric Leblond
2017-08-17 9:43 ` Phil Sutter
2017-08-16 20:43 ` [nft PATH 09/16] libnftables: move iface_cache_release to deinit Eric Leblond
2017-08-16 20:43 ` [nft PATH 10/16] libnftables: get rid of printf Eric Leblond
2017-08-17 10:01 ` Phil Sutter
2017-08-19 8:59 ` Eric Leblond
2017-08-16 20:43 ` [nft PATH 11/16] libnftables: add nft_context_set_print Eric Leblond
2017-08-16 20:43 ` Eric Leblond [this message]
2017-08-17 10:11 ` [nft PATH 12/16] libnftables: transaction support Phil Sutter
2017-08-16 20:43 ` [nft PATH 13/16] libnftables: set max_errors to 1 in library Eric Leblond
2017-08-16 20:43 ` [nft PATH 14/16] erec: add function to free list Eric Leblond
2017-08-16 20:43 ` [nft PATH 15/16] libnftables: add error handling Eric Leblond
2017-08-17 10:32 ` Phil Sutter
2017-08-19 9:04 ` Eric Leblond
2017-08-16 20:43 ` [nft PATH 16/16] libnftables: basic doxygen documentation Eric Leblond
2017-08-17 8:32 ` [nft PATCH 0/16] introduce libnftables Arturo Borrero Gonzalez
2017-08-17 8:58 ` Eric Leblond
2017-08-17 10:35 ` Florian Westphal
2017-08-17 10:47 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170816204310.3371-13-eric@regit.org \
--to=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.