From: Joerg Roedel <joro@8bytes.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Robin Murphy <robin.murphy@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
iommu@lists.linux-foundation.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: PCIe oops for NULL pointer dereference during next-20170807 and next-20170815
Date: Thu, 17 Aug 2017 09:58:26 +0200 [thread overview]
Message-ID: <20170817075825.GR30515@8bytes.org> (raw)
In-Reply-To: <2ac52f40-c34f-6c31-b8db-868c40a977a3@rock-chips.com>
On Thu, Aug 17, 2017 at 03:02:31PM +0800, Shawn Lin wrote:
> So should we revert this commit or maybe we could add some checking
> into gic-v2m and gic-v3-its to see if the dev is iommu-capable? If not,
> we should create another routine to map MSI msg.
Yes, fixing this in gic code is the right approach. I usually don't
revert patches to hide problems somewhere else.
Regards,
Joerg
next prev parent reply other threads:[~2017-08-17 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 3:34 PCIe oops for NULL pointer dereference during next-20170807 and next-20170815 Shawn Lin
2017-08-17 3:34 ` Shawn Lin
[not found] ` <c6ae57b6-1175-4ba4-b66d-d2f5393d06fc-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-17 7:02 ` Shawn Lin
2017-08-17 7:02 ` Shawn Lin
2017-08-17 7:58 ` Joerg Roedel [this message]
[not found] ` <20170817075825.GR30515-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-08-17 8:21 ` Marc Zyngier
2017-08-17 8:21 ` Marc Zyngier
2017-08-17 8:30 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817075825.GR30515@8bytes.org \
--to=joro@8bytes.org \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.