Re: [bug report] leds: Add support for Philips PCA955x I2C LED drivers

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

Hi!

> Hello Nate Case,
> 
> The patch f46e9203d9a1: "leds: Add support for Philips PCA955x I2C
> LED drivers" from Jul 16, 2008, leads to the following static checker
> warning:
> 
> 	drivers/leds/leds-pca955x.c:476 pca955x_probe()
> 	warn: this array is probably non-NULL. 'pdata->leds + i->name'
> 
> drivers/leds/leds-pca955x.c
>    465                  switch (pca955x_led->type) {
>    466                  case PCA955X_TYPE_NONE:
>    467                          break;
>    468                  case PCA955X_TYPE_GPIO:
>    469                          ngpios++;
>    470                          break;
>    471                  case PCA955X_TYPE_LED:
>    472                          /*
>    473                           * Platform data can specify LED names and
>    474                           * default triggers
>    475                           */
>    476                          if (pdata->leds[i].name)
>                                     ^^^^^^^^^^^^^^^^^^^
> The comment implies that we should be testing pdata->leds[i].name[0] to
> see if any string has been set?

Someone was already submitting patch from this one, no?

And please don't mark this one as a "bug report". There's no bug. Your
code analysis tool found a way to make kernel code shorter... well, so
what?


									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]