Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 17 Aug 2017 14:41:34 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 17.08.2017 11:22, David Hildenbrand wrote:
> > Let's reshuffle the function prototypes so we get a cleaner outline
> > of the files.
> > 
> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: David Hildenbrand <david@redhat.com>
> > ---
> >  target/s390x/cpu.h | 140 ++++++++++++++++++++++++++---------------------------
> >  1 file changed, 69 insertions(+), 71 deletions(-)  
> 
> Not sure whether this code churn here is really worth the effort ... I'd
> prefer to introduce file-specific headers for the prototypes instead,
> e.g. helper.h, mmu_helper.h, etc. ... but that's just my 0.02 € ... I
> also won't object if this patch gets included as is.

I'll stare a bit more at it to decide whether this is worthwile...