From: Stephen Hemminger <stephen@networkplumber.org>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF
Date: Thu, 17 Aug 2017 17:32:27 -0700 [thread overview]
Message-ID: <20170817173227.29bae83d@xeon-e3> (raw)
In-Reply-To: <1502994823-125017-2-git-send-email-wenzhuo.lu@intel.com>
On Fri, 18 Aug 2017 02:33:42 +0800
Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
> Currently, rte_eth_dev_mac_addr_add is used by a
> testpmd CLI to add a MAC address for VF. But the
> parameter 'pool' of this API means the VMDq pool,
> not VF.
> So, it's wrong to use it to add the VF MAC address.
> This patch provides a new API that can be used to
> add VF MAC address on i40e.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
What do other drivers do?
Sorry, a driver specific API is (almost) always the wrong solution.
next prev parent reply other threads:[~2017-08-18 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 20:51 [PATCH] net/i40e: new API to add VF MAC address from PF Wenzhuo Lu
2017-07-25 14:09 ` [PATCH v2] " Wenzhuo Lu
2017-08-17 13:05 ` Ferruh Yigit
2017-08-17 13:36 ` Lu, Wenzhuo
2017-08-17 18:33 ` [PATCH v3 0/2] fix adding VF MAC in testpmd Wenzhuo Lu
2017-08-17 18:33 ` [PATCH v3 1/2] net/i40e: new API to add VF MAC address from PF Wenzhuo Lu
2017-08-18 0:32 ` Stephen Hemminger [this message]
2017-08-18 16:43 ` Ferruh Yigit
2017-08-19 12:52 ` Lu, Wenzhuo
2017-08-17 18:33 ` [PATCH v3 2/2] app/testpmd: fix wrong API of adding VF MAC Wenzhuo Lu
2017-08-28 9:53 ` [PATCH v3 0/2] fix adding VF MAC in testpmd Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817173227.29bae83d@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.