From: Florian Westphal <fw@strlen.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com
Subject: Re: [PATCH net-next] dsa: remove unused net_device arg from handlers
Date: Thu, 17 Aug 2017 20:40:58 +0200 [thread overview]
Message-ID: <20170817184058.GA7154@breakpoint.cc> (raw)
In-Reply-To: <20170817182116.GE21715@lunn.ch>
Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Aug 17, 2017 at 04:47:00PM +0200, Florian Westphal wrote:
> > compile tested only, but saw no warnings/errors with
> > allmodconfig build.
> >
> > static int dsa_switch_rcv(struct sk_buff *skb, struct net_device *dev,
> > - struct packet_type *pt, struct net_device *orig_dev)
> > + struct packet_type *pt, struct net_device *unused)
>
> Hi Florian
>
> Looks O.K. to me. I can test it out later.
>
> Is there a bigger picture here? Do you plan to remove the second
> net_device parameter everywhere?
Its tempting, seems only af_packet uses it. I'll see if there is
another (simpler) way of getting the orig ifindex into af_packet.
next prev parent reply other threads:[~2017-08-17 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 14:47 [PATCH net-next] dsa: remove unused net_device arg from handlers Florian Westphal
2017-08-17 18:21 ` Andrew Lunn
2017-08-17 18:40 ` Florian Westphal [this message]
2017-08-17 18:53 ` Florian Fainelli
2017-08-21 17:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817184058.GA7154@breakpoint.cc \
--to=fw@strlen.de \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.