From: msuchanek <msuchanek@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jonathan Corbet <corbet@lwn.net>, Jessica Yu <jeyu@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Jason Baron <jbaron@akamai.com>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
Daniel Axtens <dja@axtens.net>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Suchanek <msuchanek@suse.de>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Michael Neuling <mikey@neuling.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Scott Wood <oss@buserror.net>,
"Oliver O'Halloran" <oohall@gmail.com>,
David Howells <dhowells@redhat.com>,
"Sylvain 'ythier' Hitier" <sylvain.hitier@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Baoquan He <bhe@redhat.com>,
linux-doc@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-kernel@vger.kernel.org, "Steven Rostedt,
" <rostedt@goodmis.org>, Tejun Heo <tj@kernel.org>,
Ilya Matveychikov <matvejchikov@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.
Date: Thu, 17 Aug 2017 23:27:40 +0200 [thread overview]
Message-ID: <20170817232740.30f7f630@naga> (raw)
In-Reply-To: <0e0a8ad11e2c9c7db02baa1bbb5a30f429586854.1503000577.git.msuchanek@suse.de>
On Thu, 17 Aug 2017 22:14:30 +0200
Michal Suchanek <msuchanek@suse.de> wrote:
> Remove quotes from argument value only if there is qoute on both
> sides.
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> arch/powerpc/kernel/fadump.c | 6 ++----
> lib/cmdline.c | 7 ++-----
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/arch/powerpc/kernel/fadump.c
> b/arch/powerpc/kernel/fadump.c index a1614d9b8a21..d7da4ce9f7ae 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -489,10 +489,8 @@ static void __init fadump_update_params(struct
> param_info *param_info, *tgt++ = ' ';
>
> /* next_arg removes one leading and one trailing '"' */
> - if (*tgt == '"')
> - shortening += 1;
> - if (*(tgt + vallen + shortening) == '"')
> - shortening += 1;
> + if ((*tgt == '"') && (*(tgt + vallen + shortening) == '"'))
s/shortening/1/ ^
in case somebody would want this patch and not the following one that
removes the code.
next prev parent reply other threads:[~2017-08-17 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 20:14 [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel Michal Suchanek
2017-08-17 20:14 ` [PATCH v7 2/4] powerpc/fadump: update documentation about 'fadump_extra_args=' parameter Michal Suchanek
2017-08-17 20:14 ` [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically Michal Suchanek
2017-08-17 21:27 ` msuchanek [this message]
2017-08-21 10:27 ` Baoquan He
2017-08-21 11:30 ` Michal Suchánek
2017-08-24 11:02 ` Michael Ellerman
2017-08-24 12:15 ` msuchanek
2017-08-17 20:14 ` [PATCH v7 4/4] boot/param: add pointer to next argument to unknown parameter callback Michal Suchanek
2017-08-24 11:04 ` Michael Ellerman
2017-08-24 12:17 ` msuchanek
2017-08-18 10:50 ` [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel Hari Bathini
2017-08-18 11:57 ` Michal Suchánek
2017-08-18 14:00 ` Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170817232740.30f7f630@naga \
--to=msuchanek@suse.de \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhe@redhat.com \
--cc=bsingharora@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dja@axtens.net \
--cc=hbathini@linux.vnet.ibm.com \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lokeshvutla@ti.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=matvejchikov@gmail.com \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sylvain.hitier@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.