From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 18 Aug 2017 12:46:23 +0100 From: Anthony PERARD To: Roger Pau Monn303251 CC: Bart Van Assche , Jens Axboe , , , Christoph Hellwig Subject: Re: [Xen-devel] [PATCH 12/12] xen-blkfront: Avoid that gcc 7 warns about fall-through when building with W=1 Message-ID: <20170818114623.GF1475@perard.uk.xensource.com> References: <20170817232311.25948-1-bart.vanassche@wdc.com> <20170817232311.25948-13-bart.vanassche@wdc.com> <20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local> Return-Path: anthony.perard@citrix.com List-ID: On Fri, Aug 18, 2017 at 09:54:01AM +0100, Roger Pau Monn303251 wrote: > On Thu, Aug 17, 2017 at 04:23:11PM -0700, Bart Van Assche wrote: > > Signed-off-by: Bart Van Assche > > Cc: Konrad Rzeszutek Wilk > > Cc: Roger Pau Monn303251 > > Cc: xen-devel@lists.xenproject.org > > --- > > drivers/block/xen-blkfront.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c > > index 98e34e4c62b8..270019e3e5d8 100644 > > --- a/drivers/block/xen-blkfront.c > > +++ b/drivers/block/xen-blkfront.c > > @@ -2456,7 +2456,7 @@ static void blkback_changed(struct xenbus_device *dev, > > case XenbusStateClosed: > > if (dev->state == XenbusStateClosed) > > break; > > - /* Missed the backend's Closing state -- fallthrough */ > > + /* fall through */ > > This is losing information present in the original comment. Would > splitting the comment into two make gcc happy? What about: - /* Missed the backend's Closing state -- fallthrough */ + /* fallthrough -- Missed the backend's Closing state */ FIY: https://gcc.gnu.org/onlinedocs/gcc-7.2.0/gcc/Warning-Options.html#index-Wimplicit-fallthrough A dash seems to be needed between "fall through" and a extra comment, with fallthrough first. Regards, -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 12/12] xen-blkfront: Avoid that gcc 7 warns about fall-through when building with W=1 Date: Fri, 18 Aug 2017 12:46:23 +0100 Message-ID: <20170818114623.GF1475@perard.uk.xensource.com> References: <20170817232311.25948-1-bart.vanassche@wdc.com> <20170817232311.25948-13-bart.vanassche@wdc.com> <20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1difjQ-0004u9-Qw for xen-devel@lists.xenproject.org; Fri, 18 Aug 2017 11:46:28 +0000 Content-Disposition: inline In-Reply-To: <20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Roger Pau Monn303251 Cc: Bart Van Assche , Jens Axboe , linux-block@vger.kernel.org, Christoph Hellwig , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBBdWcgMTgsIDIwMTcgYXQgMDk6NTQ6MDFBTSArMDEwMCwgUm9nZXIgUGF1IE1vbm4z MDMyNTEgd3JvdGU6Cj4gT24gVGh1LCBBdWcgMTcsIDIwMTcgYXQgMDQ6MjM6MTFQTSAtMDcwMCwg QmFydCBWYW4gQXNzY2hlIHdyb3RlOgo+ID4gU2lnbmVkLW9mZi1ieTogQmFydCBWYW4gQXNzY2hl IDxiYXJ0LnZhbmFzc2NoZUB3ZGMuY29tPgo+ID4gQ2M6IEtvbnJhZCBSemVzenV0ZWsgV2lsayA8 a29ucmFkLndpbGtAb3JhY2xlLmNvbT4KPiA+IENjOiBSb2dlciBQYXUgTW9ubjMwMzI1MSA8cm9n ZXIucGF1QGNpdHJpeC5jb20+Cj4gPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3Jn Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jIHwgMiArLQo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYyBiL2RyaXZlcnMvYmxvY2sveGVu LWJsa2Zyb250LmMKPiA+IGluZGV4IDk4ZTM0ZTRjNjJiOC4uMjcwMDE5ZTNlNWQ4IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYwo+ID4gKysrIGIvZHJpdmVycy9i bG9jay94ZW4tYmxrZnJvbnQuYwo+ID4gQEAgLTI0NTYsNyArMjQ1Niw3IEBAIHN0YXRpYyB2b2lk IGJsa2JhY2tfY2hhbmdlZChzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LAo+ID4gIAljYXNlIFhl bmJ1c1N0YXRlQ2xvc2VkOgo+ID4gIAkJaWYgKGRldi0+c3RhdGUgPT0gWGVuYnVzU3RhdGVDbG9z ZWQpCj4gPiAgCQkJYnJlYWs7Cj4gPiAtCQkvKiBNaXNzZWQgdGhlIGJhY2tlbmQncyBDbG9zaW5n IHN0YXRlIC0tIGZhbGx0aHJvdWdoICovCj4gPiArCQkvKiBmYWxsIHRocm91Z2ggKi8KPiAKPiBU aGlzIGlzIGxvc2luZyBpbmZvcm1hdGlvbiBwcmVzZW50IGluIHRoZSBvcmlnaW5hbCBjb21tZW50 LiBXb3VsZAo+IHNwbGl0dGluZyB0aGUgY29tbWVudCBpbnRvIHR3byBtYWtlIGdjYyBoYXBweT8K CldoYXQgYWJvdXQ6CgotCQkvKiBNaXNzZWQgdGhlIGJhY2tlbmQncyBDbG9zaW5nIHN0YXRlIC0t IGZhbGx0aHJvdWdoICovCisJCS8qIGZhbGx0aHJvdWdoIC0tIE1pc3NlZCB0aGUgYmFja2VuZCdz IENsb3Npbmcgc3RhdGUgKi8KCkZJWToKaHR0cHM6Ly9nY2MuZ251Lm9yZy9vbmxpbmVkb2NzL2dj Yy03LjIuMC9nY2MvV2FybmluZy1PcHRpb25zLmh0bWwjaW5kZXgtV2ltcGxpY2l0LWZhbGx0aHJv dWdoCgpBIGRhc2ggc2VlbXMgdG8gYmUgbmVlZGVkIGJldHdlZW4gImZhbGwgdGhyb3VnaCIgYW5k IGEgZXh0cmEgY29tbWVudCwKd2l0aCBmYWxsdGhyb3VnaCBmaXJzdC4KClJlZ2FyZHMsCgotLSAK QW50aG9ueSBQRVJBUkQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=