From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH 07/13] dax: Inline dax_pmd_insert_mapping() into the callsite Date: Fri, 18 Aug 2017 16:12:27 -0600 Message-ID: <20170818221226.GF32627@linux.intel.com> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-8-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Boaz Harrosh , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Lutomirski , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20170817160815.30466-8-jack-AlSwsSmVLrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: linux-ext4.vger.kernel.org On Thu, Aug 17, 2017 at 06:08:09PM +0200, Jan Kara wrote: > dax_pmd_insert_mapping() has only one callsite and we will need to > further fine tune what it does for synchronous faults. Just inline it > into the callsite so that we don't have to pass awkward bools around. > > Signed-off-by: Jan Kara Sure, looks good. Reviewed-by: Ross Zwisler From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3A7A521E7903B for ; Fri, 18 Aug 2017 15:10:00 -0700 (PDT) Date: Fri, 18 Aug 2017 16:12:27 -0600 From: Ross Zwisler Subject: Re: [PATCH 07/13] dax: Inline dax_pmd_insert_mapping() into the callsite Message-ID: <20170818221226.GF32627@linux.intel.com> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-8-jack@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170817160815.30466-8-jack@suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jan Kara Cc: Christoph Hellwig , Boaz Harrosh , linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org, Andy Lutomirski , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org List-ID: On Thu, Aug 17, 2017 at 06:08:09PM +0200, Jan Kara wrote: > dax_pmd_insert_mapping() has only one callsite and we will need to > further fine tune what it does for synchronous faults. Just inline it > into the callsite so that we don't have to pass awkward bools around. > > Signed-off-by: Jan Kara Sure, looks good. Reviewed-by: Ross Zwisler _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:44972 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751843AbdHRWM2 (ORCPT ); Fri, 18 Aug 2017 18:12:28 -0400 Date: Fri, 18 Aug 2017 16:12:27 -0600 From: Ross Zwisler Subject: Re: [PATCH 07/13] dax: Inline dax_pmd_insert_mapping() into the callsite Message-ID: <20170818221226.GF32627@linux.intel.com> References: <20170817160815.30466-1-jack@suse.cz> <20170817160815.30466-8-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170817160815.30466-8-jack@suse.cz> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Andy Lutomirski , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Christoph Hellwig , Ross Zwisler , Dan Williams , Boaz Harrosh On Thu, Aug 17, 2017 at 06:08:09PM +0200, Jan Kara wrote: > dax_pmd_insert_mapping() has only one callsite and we will need to > further fine tune what it does for synchronous faults. Just inline it > into the callsite so that we don't have to pass awkward bools around. > > Signed-off-by: Jan Kara Sure, looks good. Reviewed-by: Ross Zwisler