From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michal Suchanek <msuchanek@suse.de>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Phil Sutter <phil@nwl.cc>, Josh Zimmerman <joshz@google.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Ludovic Desroches <ludovic.desroches@o2linux.fr>,
linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] Do not disable driver and bus shutdown hook when class shutdown hook is set.
Date: Sat, 19 Aug 2017 20:29:59 +0300 [thread overview]
Message-ID: <20170819172959.iu46r2jm7unmbb4x@linux.intel.com> (raw)
In-Reply-To: <20170819170340.GA12870@kroah.com>
On Sat, Aug 19, 2017 at 10:03:40AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Aug 19, 2017 at 03:03:53PM +0300, Jarkko Sakkinen wrote:
> > On Fri, Aug 11, 2017 at 03:44:43PM +0200, Michal Suchanek wrote:
> > > As seen from the implementation of the single class shutdown hook this
> > > is not very sound design.
> > >
> > > Rename the class shutdown hook to shutdown_pre to make it clear it runs
> > > before the driver shutdown hook.
> > >
> > > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> >
> > I already gave this reviewed-by but cannot apply it because there's no
> > ack from device maintainers yet.
>
> I'm on vacation at the moment and will look at this when I get back in a
> week, please give me a chance.
>
> thanks,
>
> greg k-h
Take your time! I don't think this patch is critical. Thanks.
/Jarkko
prev parent reply other threads:[~2017-08-19 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 13:44 [PATCH v2] Do not disable driver and bus shutdown hook when class shutdown hook is set Michal Suchanek
2017-08-14 9:52 ` Jarkko Sakkinen
2017-08-19 12:03 ` Jarkko Sakkinen
2017-08-19 17:03 ` Greg Kroah-Hartman
2017-08-19 17:29 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170819172959.iu46r2jm7unmbb4x@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=joshz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@o2linux.fr \
--cc=madalin.bucur@nxp.com \
--cc=mchehab@kernel.org \
--cc=msuchanek@suse.de \
--cc=peterhuewe@gmx.de \
--cc=phil@nwl.cc \
--cc=rafael.j.wysocki@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.