All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: light: tsl2583: constify i2c_device_id
Date: Sun, 20 Aug 2017 10:17:38 +0100	[thread overview]
Message-ID: <20170820101738.676604de@archlinux> (raw)
In-Reply-To: <1503168458-17676-4-git-send-email-arvind.yadav.cs@gmail.com>

On Sun, 20 Aug 2017 00:17:38 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied.

Thanks,

Jonathan
> ---
>  drivers/iio/light/tsl2583.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
> index 1679181..fb711ed 100644
> --- a/drivers/iio/light/tsl2583.c
> +++ b/drivers/iio/light/tsl2583.c
> @@ -924,7 +924,7 @@ static const struct dev_pm_ops tsl2583_pm_ops = {
>  	SET_RUNTIME_PM_OPS(tsl2583_suspend, tsl2583_resume, NULL)
>  };
>  
> -static struct i2c_device_id tsl2583_idtable[] = {
> +static const struct i2c_device_id tsl2583_idtable[] = {
>  	{ "tsl2580", 0 },
>  	{ "tsl2581", 1 },
>  	{ "tsl2583", 2 },


      reply	other threads:[~2017-08-20  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 18:47 [PATCH 0/3] constify iio i2c_device_id Arvind Yadav
2017-08-19 18:47 ` [PATCH 1/3] iio: accel: bma180: constify i2c_device_id Arvind Yadav
2017-08-20  9:16   ` Jonathan Cameron
2017-08-19 18:47 ` [PATCH 2/3] iio: light: apds9300: " Arvind Yadav
2017-08-20  9:17   ` Jonathan Cameron
2017-08-19 18:47 ` [PATCH 3/3] iio: light: tsl2583: " Arvind Yadav
2017-08-20  9:17   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820101738.676604de@archlinux \
    --to=jic23@kernel.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.