From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] wired performance
Date: Sun, 20 Aug 2017 16:05:07 +0200 [thread overview]
Message-ID: <20170820140507.GA24150@lunn.ch> (raw)
In-Reply-To: <5468456.iLjU66Egku@sven-edge>
> And there is currently no special batman-adv support for the flow
> dissector [1] in the kernel. This could be also a reason why multiple flows
> are not distributed well to different cores when you enable RPS/XPS. It is not
> yet know whether this will actually be helpful but at least someone interested
> could do same research and implement a proof-of-concept patches for further
> testing.
Hi Sven
DSA just added a patch to help with flow dissectors. Maybe it can be
generalized and made to work for BATMAN as well?
commit 43e665287f931a167cd2eea3387efda901bff0ce
Author: John Crispin <john@phrozen.org>
Date: Wed Aug 9 14:41:19 2017 +0200
net-next: dsa: fix flow dissection
RPS and probably other kernel features are currently broken on some if not
all DSA devices. The root cause of this is that skb_hash will call the
flow_dissector. At this point the skb still contains the magic switch
header and the skb->protocol field is not set up to the correct 802.3
value yet. By the time the tag specific code is called, removing the header
and properly setting the protocol an invalid hash is already set. In the
case of the mt7530 this will result in all flows always having the same
hash.
next prev parent reply other threads:[~2017-08-20 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 15:39 [B.A.T.M.A.N.] wired performance dan
2017-08-19 18:25 ` dan
2017-08-19 23:42 ` dan
2017-08-20 7:35 ` Sven Eckelmann
2017-08-20 14:05 ` Andrew Lunn [this message]
2017-08-20 17:48 ` dan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170820140507.GA24150@lunn.ch \
--to=andrew@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.