All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, keith.busch@intel.com
Subject: Re: [Qemu-devel] [PATCH 1/2] nvme: Update header to include SGL	related macros and members
Date: Mon, 21 Aug 2017 15:06:45 +0200	[thread overview]
Message-ID: <20170821130645.GA16745@lst.de> (raw)
In-Reply-To: <20170606073806.8180-1-quwenruo@cn.fujitsu.com>

On Tue, Jun 06, 2017 at 03:38:05PM +0800, Qu Wenruo wrote:
> Update nvme header to catch up with kernel.
> Most of the newly added members are from 1.2 and 1.3 spec, while the
> status code is only kept the same with kernel (around 1.1 spec).
> 
> The major update is to add Scatter Gather List related macros and
> members, for later SGL support implementation.

The keyed sgls are only for nvme over fabrics (aka network) controllers,
and make no sense here.

Looks like this was copy & pasted a little to eager from the kernel
driver :)

      parent reply	other threads:[~2017-08-21 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06  7:38 [Qemu-devel] [PATCH 1/2] nvme: Update header to include SGL related macros and members Qu Wenruo
2017-06-06  7:38 ` [Qemu-devel] [PATCH 2/2] nvme: Check PSDT flag for admin and rw command Qu Wenruo
2017-08-21 13:07   ` Christoph Hellwig
2017-06-26 20:50 ` [Qemu-devel] [Qemu-block] [PATCH 1/2] nvme: Update header to include SGL related macros and members John Snow
2017-08-21 13:06 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821130645.GA16745@lst.de \
    --to=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quwenruo@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.