All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 7/7] tests: add tcp option set support / tcp mss mangling test cases
Date: Mon, 21 Aug 2017 16:14:17 +0200	[thread overview]
Message-ID: <20170821141417.GF6076@salvia> (raw)
In-Reply-To: <20170819231413.15164-8-fw@strlen.de>

Thanks for adding tests.

On Sun, Aug 20, 2017 at 01:14:13AM +0200, Florian Westphal wrote:
> diff --git a/tests/py/inet/tcpopt.t b/tests/py/inet/tcpopt.t
> index a42ecd250a9c..94ad3fc4c645 100644
> --- a/tests/py/inet/tcpopt.t
> +++ b/tests/py/inet/tcpopt.t
> @@ -38,3 +38,6 @@ tcp option sack window 1;fail
>  
>  tcp option window exists;ok
>  tcp option window missing;ok
> +
> +tcp option maxseg size set 1360;ok;tcp option mss set 1360

This is a follow up, related to 5/7.

Why do we need this assymetry at all?

  reply	other threads:[~2017-08-21 14:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 23:14 [PATCH nft 0/7] tcp mss mangling support Florian Westphal
2017-08-19 23:14 ` [PATCH libnftnl 1/7] exthdr: tcp option set support Florian Westphal
2017-08-21 14:07   ` Pablo Neira Ayuso
2017-08-19 23:14 ` [PATCH libnftnl 2/7] rt: tcpmss get support Florian Westphal
2017-08-21 14:08   ` Pablo Neira Ayuso
2017-08-19 23:14 ` [PATCH nft 3/7] exthdr: move print of tcp options to tcpopt.c Florian Westphal
2017-08-19 23:14 ` [PATCH nft 4/7] src: add tcp options set support Florian Westphal
2017-08-21 14:09   ` Pablo Neira Ayuso
2017-08-19 23:14 ` [PATCH nft 5/7] src: implement shortcut for tcp mss size mangling Florian Westphal
2017-08-21 14:12   ` Pablo Neira Ayuso
2017-08-21 14:23     ` Florian Westphal
2017-08-19 23:14 ` [PATCH nft 6/7] rt: add path mss support Florian Westphal
2017-08-21 14:12   ` Pablo Neira Ayuso
2017-08-19 23:14 ` [PATCH nft 7/7] tests: add tcp option set support / tcp mss mangling test cases Florian Westphal
2017-08-21 14:14   ` Pablo Neira Ayuso [this message]
2017-08-21 14:28     ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821141417.GF6076@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.