From: Stephen Hemminger <stephen@networkplumber.org>
To: Yipeng Wang <yipeng1.wang@intel.com>
Cc: vincent.jardin@6wind.com, bruce.richardson@intel.com,
konstantin.ananyev@intel.com, thomas@monjalon.net, dev@dpdk.org,
charlie.tai@intel.com, sameh.gobriel@intel.com,
ren.wang@intel.com
Subject: Re: [PATCH 1/7] member: implement main API
Date: Mon, 21 Aug 2017 20:59:05 -0700 [thread overview]
Message-ID: <20170821205905.1704ec88@xeon-e3> (raw)
In-Reply-To: <1503361193-36699-2-git-send-email-yipeng1.wang@intel.com>
On Mon, 21 Aug 2017 17:19:47 -0700
Yipeng Wang <yipeng1.wang@intel.com> wrote:
> +int
> +rte_member_lookup(const void *ss, const void *key,
> + MEMBER_SET_TYPE *set_id)
> +{
> + const struct rte_member_setsum *setsum = ss;
> + if (setsum == NULL || key == NULL || set_id == NULL)
> + return -EINVAL;
> +
> + int ret = 0;
Don't needlessly initialize all variable.
In all code paths, ret is set.
In fact you could just make all cases of the switch into return
and compiler could optimize it as a tail call.
next prev parent reply other threads:[~2017-08-22 3:59 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 0:19 [PATCH 0/7] Add Membership Library Yipeng Wang
2017-08-22 0:19 ` [PATCH 1/7] member: implement main API Yipeng Wang
2017-08-22 3:59 ` Stephen Hemminger [this message]
2017-08-22 10:02 ` Luca Boccassi
2017-08-24 9:35 ` Ferruh Yigit
2017-08-24 9:55 ` Luca Boccassi
2017-08-24 10:32 ` Ferruh Yigit
2017-09-02 12:55 ` Luca Boccassi
2017-09-02 23:49 ` Luca Boccassi
2017-08-24 18:38 ` Wang, Yipeng1
2017-09-02 12:54 ` Luca Boccassi
2017-08-22 0:19 ` [PATCH 2/7] member: implement HT mode Yipeng Wang
2017-08-22 0:19 ` [PATCH 3/7] member: implement vBF mode Yipeng Wang
2017-08-22 0:19 ` [PATCH 4/7] member: add AVX for HT mode Yipeng Wang
2017-08-22 0:19 ` [PATCH 5/7] member: enable the library Yipeng Wang
2017-08-22 0:19 ` [PATCH 6/7] test/member: add functional and perf tests Yipeng Wang
2017-08-22 0:19 ` [PATCH 7/7] doc: add membership documentation Yipeng Wang
2017-08-22 4:01 ` [PATCH 0/7] Add Membership Library Stephen Hemminger
2017-08-23 2:58 ` Wang, Yipeng1
2017-09-02 1:24 ` [PATCH v2 " Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 1/7] member: implement main API Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 2/7] member: implement HT mode Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 3/7] member: implement vBF mode Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 4/7] member: add AVX for HT mode Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 5/7] member: enable the library Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 6/7] test/member: add functional and perf tests Yipeng Wang
2017-09-02 1:24 ` [PATCH v2 7/7] doc: add membership documentation Yipeng Wang
2017-09-04 13:19 ` Mcnamara, John
2017-09-05 23:59 ` [PATCH v3 0/7] Add Membership Library Yipeng Wang
2017-09-05 23:59 ` [PATCH v3 1/7] member: implement main API Yipeng Wang
2017-09-22 10:47 ` Thomas Monjalon
2017-09-25 14:15 ` De Lara Guarch, Pablo
2017-09-05 23:59 ` [PATCH v3 2/7] member: implement HT mode Yipeng Wang
2017-09-05 23:59 ` [PATCH v3 3/7] member: implement vBF mode Yipeng Wang
2017-09-05 23:59 ` [PATCH v3 4/7] member: add AVX for HT mode Yipeng Wang
2017-09-05 23:59 ` [PATCH v3 5/7] member: enable the library Yipeng Wang
2017-09-22 10:48 ` Thomas Monjalon
2017-09-05 23:59 ` [PATCH v3 6/7] test/member: add functional and perf tests Yipeng Wang
2017-09-05 23:59 ` [PATCH v3 7/7] doc: add membership documentation Yipeng Wang
2017-09-18 18:42 ` Mcnamara, John
2017-09-25 12:30 ` De Lara Guarch, Pablo
2017-09-27 17:40 ` [PATCH v4 0/7] Add Membership Library Yipeng Wang
2017-09-27 17:40 ` [PATCH v4 1/7] member: implement main API Yipeng Wang
2017-10-02 10:04 ` De Lara Guarch, Pablo
2017-09-27 17:40 ` [PATCH v4 2/7] member: implement HT mode Yipeng Wang
2017-10-02 13:30 ` De Lara Guarch, Pablo
2017-10-03 1:18 ` Wang, Yipeng1
2017-09-27 17:40 ` [PATCH v4 3/7] member: implement vBF mode Yipeng Wang
2017-10-02 15:44 ` De Lara Guarch, Pablo
2017-10-03 1:24 ` Wang, Yipeng1
2017-09-27 17:40 ` [PATCH v4 4/7] member: add AVX for HT mode Yipeng Wang
2017-09-27 17:40 ` [PATCH v4 5/7] member: enable the library Yipeng Wang
2017-10-02 15:47 ` De Lara Guarch, Pablo
2017-09-27 17:40 ` [PATCH v4 6/7] test/member: add functional and perf tests Yipeng Wang
2017-10-02 16:20 ` De Lara Guarch, Pablo
2017-09-27 17:40 ` [PATCH v4 7/7] doc: add membership documentation Yipeng Wang
2017-10-03 4:31 ` [PATCH v5 0/7] Add Membership Library Yipeng Wang
2017-10-03 4:31 ` [PATCH v5 1/7] member: implement main API Yipeng Wang
2017-10-03 8:42 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 2/7] member: implement HT mode Yipeng Wang
2017-10-03 8:47 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 3/7] member: implement vBF mode Yipeng Wang
2017-10-03 8:50 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 4/7] member: add AVX for HT mode Yipeng Wang
2017-10-03 9:01 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 5/7] member: enable the library Yipeng Wang
2017-10-03 9:04 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 6/7] test/member: add functional and perf tests Yipeng Wang
2017-10-03 9:07 ` De Lara Guarch, Pablo
2017-10-03 4:31 ` [PATCH v5 7/7] doc: add membership documentation Yipeng Wang
2017-10-03 9:08 ` De Lara Guarch, Pablo
2017-10-04 3:12 ` [PATCH v6 0/7] Add Membership Library Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 1/7] member: implement main API Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 2/7] member: implement HT mode Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 3/7] member: implement vBF mode Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 4/7] member: add AVX for HT mode Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 5/7] member: enable the library Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 6/7] test/member: add functional and perf tests Yipeng Wang
2017-10-04 3:12 ` [PATCH v6 7/7] doc: add membership documentation Yipeng Wang
2017-10-04 13:44 ` Mcnamara, John
2017-10-08 22:14 ` [PATCH v6 0/7] Add Membership Library Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821205905.1704ec88@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=charlie.tai@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=ren.wang@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=vincent.jardin@6wind.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.