From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, Boqun Feng <boqun.feng@gmail.com>,
Andrew Hunter <ahh@google.com>,
Maged Michael <maged.michael@gmail.com>,
gromer@google.com, Avi Kivity <avi@scylladb.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Dave Watson <davejwatson@fb.com>
Subject: Re: [PATCH v2] membarrier: Document scheduler barrier requirements
Date: Mon, 21 Aug 2017 23:20:22 -0700 [thread overview]
Message-ID: <20170822062022.GZ11320@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170821084236.hsxtqtmsno7aqnls@hirez.programming.kicks-ass.net>
On Mon, Aug 21, 2017 at 10:42:36AM +0200, Peter Zijlstra wrote:
> On Fri, Aug 18, 2017 at 09:39:16PM -0700, Mathieu Desnoyers wrote:
> > @@ -3295,6 +3301,9 @@ static void __sched notrace __schedule(bool preempt)
> > * Make sure that signal_pending_state()->signal_pending() below
> > * can't be reordered with __set_current_state(TASK_INTERRUPTIBLE)
> > * done by the caller to avoid the race with signal_wake_up().
> > + *
> > + * The membarrier system call requires a full memory barrier
> > + * after coming from user-space, before storing to rq->curr.
> > */
> > smp_mb__before_spinlock();
> > rq_lock(rq, &rf);
>
> Merge conflict here, current tip is over to smp_mb__after_spinlock().
Would some tree other than -rcu be better for that commit?
Thanx, Paul
next prev parent reply other threads:[~2017-08-22 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 4:39 [PATCH v2] membarrier: Document scheduler barrier requirements Mathieu Desnoyers
2017-08-20 5:05 ` Paul E. McKenney
2017-08-21 8:42 ` Peter Zijlstra
2017-08-22 6:20 ` Paul E. McKenney [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-19 19:56 Mathieu Desnoyers
2017-09-19 21:47 ` Andrea Parri
2017-09-19 22:02 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822062022.GZ11320@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=ahh@google.com \
--cc=avi@scylladb.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=davejwatson@fb.com \
--cc=gromer@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maged.michael@gmail.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.