From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/perf: really install manpages by make install-man
Date: Tue, 22 Aug 2017 12:46:29 -0300 [thread overview]
Message-ID: <20170822154629.GU10891@kernel.org> (raw)
In-Reply-To: <150322915300.129715.13645857235229756834.stgit@buzz>
Em Sun, Aug 20, 2017 at 02:39:13PM +0300, Konstantin Khlebnikov escreveu:
> Target install-man builds them but forget to install.
Thanks, applied, I guess nobody noticed that because the man pages _are_
installed when using plain 'make -C tools/perf install', as it calls
'try-install-man' and it, in turn, uses do-install-man.
- Arnaldo
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> tools/perf/Documentation/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile
> index 098cfb9ca8f0..db11478e30b4 100644
> --- a/tools/perf/Documentation/Makefile
> +++ b/tools/perf/Documentation/Makefile
> @@ -192,7 +192,7 @@ do-install-man: man
> # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \
> # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
>
> -install-man: check-man-tools man
> +install-man: check-man-tools man do-install-man
>
> ifdef missing_tools
> DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)
next prev parent reply other threads:[~2017-08-22 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 11:39 [PATCH] tools/perf: really install manpages by make install-man Konstantin Khlebnikov
2017-08-22 15:46 ` Arnaldo Carvalho de Melo [this message]
2017-08-24 8:23 ` [tip:perf/core] perf tools: Really install manpages via 'make install-man' tip-bot for Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822154629.GU10891@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.