All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Lukáš Doktor" <ldoktor@redhat.com>,
	qemu-devel@nongnu.org, famz@redhat.com, apahim@redhat.com,
	mreitz@redhat.com, "Daniel P. Berrange" <berrange@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes
Date: Tue, 22 Aug 2017 16:07:09 -0300	[thread overview]
Message-ID: <20170822190709.GJ19998@localhost.localdomain> (raw)
In-Reply-To: <c560b757-6bb1-2ded-a25b-193e5f9318c2@amsat.org>

(CCing Cleber and Stefan)

On Tue, Aug 22, 2017 at 07:19:45AM -0300, Philippe Mathieu-Daudé wrote:
[...]
> Can we predict how the python scripts will evolve? Only fast-testing?
> 

I guess it depends on how you define "fast".  Does "fast-testing"
include a full device-crash-test run (that could take ~30
minutes) or the full set of iotests?


> Is there some users hacking on qemu.py unaware they can/should use
> libvirt-python?

I believe the existing users of qemu.py wouldn't want to have
dependencies on libvirt or other external modules (e.g. code that
test specific QMP commands and/or is run by "make check").


> If so, shouldn't we think about running more tests through libvirt and add
> effort there?

Even if the existing test code wouldn't benefit from libvirt, I
agree there is some value in writing test code that uses libvirt.
But in this case would the test code belong to the QEMU source
tree, or somewhere else?

-- 
Eduardo

  reply	other threads:[~2017-08-22 19:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 14:26 [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 01/10] " Lukáš Doktor
2017-08-24 22:38   ` Cleber Rosa
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 02/10] qemu|qtest: Avoid dangerous arguments Lukáš Doktor
2017-08-24 22:55   ` Cleber Rosa
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 03/10] qemu.py: Use iteritems rather than keys() Lukáš Doktor
2017-08-24 22:56   ` Cleber Rosa
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 04/10] qemu.py: Simplify QMP key-conversion Lukáš Doktor
2017-08-24 22:59   ` Cleber Rosa
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 05/10] qemu.py: Use custom exceptions rather than Exception Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 06/10] qmp.py: Couple of pylint/style fixes Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 08/10] qmp.py: Avoid "has_key" usage Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 09/10] qmp.py: Avoid overriding a builtin object Lukáš Doktor
2017-08-18 14:26 ` [Qemu-devel] [PATCH v6 10/10] qtest.py: Few pylint/style fixes Lukáš Doktor
2017-08-21 21:51 ` [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes John Snow
2017-08-22  7:24   ` Markus Armbruster
2017-08-22 10:19     ` Philippe Mathieu-Daudé
2017-08-22 19:07       ` Eduardo Habkost [this message]
2017-08-24 12:15         ` Stefan Hajnoczi
2017-08-24 12:49           ` Philippe Mathieu-Daudé
2017-08-22 13:56     ` Paolo Bonzini
2017-08-22 18:11     ` John Snow
2017-08-22 18:51     ` Eduardo Habkost
2017-08-30 21:18 ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170822190709.GJ19998@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=apahim@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ldoktor@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.