All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shurong Zhang <zhang_shurong@foxmail.com>
Cc: Jens Frederich <jfrederich@gmail.com>,
	Daniel Drake <dsd@laptop.org>,
	Jon Nettleton <jon.nettleton@gmail.com>,
	devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: olpc_dcon: Change fixed function names with "%s: ", __func__
Date: Tue, 22 Aug 2017 22:34:45 -0700	[thread overview]
Message-ID: <20170823053445.GA23426@kroah.com> (raw)
In-Reply-To: <20170823050652.GA6353@MarvinZhang.kernel@gmail.com>

On Wed, Aug 23, 2017 at 01:06:52PM +0800, Shurong Zhang wrote:
> Replace hard-coded function names in strings with "%s", __func__
>     in the olpc_dcon.c file. Issue found by checkpatch.pl.

What is up with the odd indentation?

And why did you send this twice?  Which patch should I use?  I'll just
drop both, please fix up and send a v2 properly.

thanks,

greg k-h

           reply	other threads:[~2017-08-23  5:34 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20170823050652.GA6353@MarvinZhang.kernel@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823053445.GA23426@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dsd@laptop.org \
    --cc=jfrederich@gmail.com \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhang_shurong@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.