From: Greg KH <greg@kroah.com>
To: Nick Fox <fox.nicholas.j@gmail.com>
Cc: arve@android.com, riandrews@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch)
Date: Tue, 22 Aug 2017 22:38:03 -0700 [thread overview]
Message-ID: <20170823053803.GD23426@kroah.com> (raw)
In-Reply-To: <20170823025537.21991-2-fox.nicholas.j@gmail.com>
On Tue, Aug 22, 2017 at 10:55:37PM -0400, Nick Fox wrote:
> Change argument to kmalloc() to fix style issue, reported by checkpatch
>
> Signed-off-by: Nick Fox <fox.nicholas.j@gmail.com>
> ---
> drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index b06f4cee9c7c..bb2c1449cbcf 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -45,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
> if (!pages)
> return -ENOMEM;
>
> - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> + table = kmalloc(sizeof(*table), GFP_KERNEL);
This doesn't apply to linux-next at all, what tree are you working
against? Always work off of the correct tree please...
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-23 5:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 1:04 [PATCH] drivers: staging: android: Fix style/formatting issues Nick Fox
2017-08-23 1:38 ` Greg KH
2017-08-23 2:55 ` [PATCH 1/2] staging: android: ion: Remove extra line (checkpatch) Nick Fox
2017-08-23 2:55 ` [PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch) Nick Fox
2017-08-23 5:38 ` Greg KH [this message]
[not found] ` <CAAmVuH--a1Z0BmTAjvR5O-zobwGsVCQ+BqBZ8Wunsc0SY5W4Dw@mail.gmail.com>
2017-08-23 23:18 ` Greg KH
2017-08-23 5:38 ` [PATCH 1/2] staging: android: ion: Remove extra line (checkpatch) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823053803.GD23426@kroah.com \
--to=greg@kroah.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=fox.nicholas.j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.