From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH 2/2] net/mlx5: fix probe failure report
Date: Wed, 23 Aug 2017 11:44:13 +0200 [thread overview]
Message-ID: <20170823094413.GT12995@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <1502627112-53405-2-git-send-email-matan@mellanox.com>
On Sun, Aug 13, 2017 at 03:25:12PM +0300, Matan Azrad wrote:
> The corrupted code doesn't return error when probe function
> fails due to error in device mac address getting.
> By this way, the probe function may return success even if the
> ETH dev is not allocated.
>
> Hence, the probe caller, for example failsafe PMD, fails when it
> tries to get ETH dev after the device was plugged out while mlx5
> was probing it.
>
> The fix adds error report to the probe caller when priv_get_mac fails
> and in all other failure options which are missing it.
>
> By this way, it prevents the unexpected behavior to miss ETH device
> after the device was probed successfully.
>
> This bug was already present in the original code taken from mlx4.
>
> Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters")
> Fixes: 1371f4df16bc ("mlx5: check port is configured as ethernet device")
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> Cc: stable@dpdk.org
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-08-23 9:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 12:25 [PATCH 1/2] net/mlx5: support device removal event Matan Azrad
2017-08-13 12:25 ` [PATCH 2/2] net/mlx5: fix probe failure report Matan Azrad
2017-08-23 9:44 ` Nélio Laranjeiro [this message]
2017-09-01 10:40 ` [dpdk-stable] " Ferruh Yigit
2017-08-23 9:40 ` [PATCH 1/2] net/mlx5: support device removal event Nélio Laranjeiro
2017-08-23 19:44 ` Matan Azrad
2017-08-24 7:38 ` Nélio Laranjeiro
2017-08-24 14:33 ` Matan Azrad
2017-08-25 8:29 ` Nélio Laranjeiro
2017-08-29 8:30 ` [PATCH v2] " Matan Azrad
2017-09-04 12:49 ` Nélio Laranjeiro
2017-09-04 13:55 ` [PATCH v3] " Matan Azrad
2017-09-04 15:33 ` Adrien Mazarguil
2017-09-04 17:52 ` Matan Azrad
2017-09-05 9:28 ` Adrien Mazarguil
2017-09-05 10:38 ` Matan Azrad
2017-09-05 12:01 ` Adrien Mazarguil
2017-09-05 13:36 ` Matan Azrad
2017-09-06 7:12 ` Adrien Mazarguil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823094413.GT12995@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.