From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 1/5] block: Warn if blk_queue_rq_timed_out() is called for a blk-mq queue
Date: Wed, 23 Aug 2017 20:03:09 +0200 [thread overview]
Message-ID: <20170823180309.GB5802@lst.de> (raw)
In-Reply-To: <20170823175633.12680-2-bart.vanassche@wdc.com>
On Wed, Aug 23, 2017 at 10:56:29AM -0700, Bart Van Assche wrote:
> The timeout handler set by blk_queue_rq_timed_out() is only used
> in single queue mode. Calling this function for blk-mq drivers is
> wrong. Hence issue a warning if this function is called by a blk-mq
> driver.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-08-23 18:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 17:56 [PATCH 0/5] skd fixes for kernel v4.14 Bart Van Assche
2017-08-23 17:56 ` [PATCH 1/5] block: Warn if blk_queue_rq_timed_out() is called for a blk-mq queue Bart Van Assche
2017-08-23 18:03 ` Christoph Hellwig [this message]
2017-08-23 17:56 ` [PATCH 2/5] skd: Report completion mismatches once Bart Van Assche
2017-08-23 18:03 ` Christoph Hellwig
2017-08-23 17:56 ` [PATCH 3/5] skd: Inline skd_process_request() Bart Van Assche
2017-08-23 18:03 ` Christoph Hellwig
2017-08-23 17:56 ` [PATCH 4/5] skd: Avoid double completions in case of a timeout Bart Van Assche
2017-08-23 18:08 ` Christoph Hellwig
2017-08-24 15:12 ` Bart Van Assche
2017-08-23 17:56 ` [PATCH 5/5] skd: Change default interrupt mode to MSI-X Bart Van Assche
2017-08-23 18:06 ` Christoph Hellwig
2017-08-23 18:03 ` [PATCH 0/5] skd fixes for kernel v4.14 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823180309.GB5802@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.