All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sandeep Singh <Sandeep.Singh@amd.com>
Cc: mathias.nyman@intel.com, ben@decadent.org.uk,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH] usb:xhci:Fix regression when ATI chipsets detected
Date: Wed, 23 Aug 2017 16:03:19 -0700	[thread overview]
Message-ID: <20170823230319.GC5193@kroah.com> (raw)
In-Reply-To: <1503485760-15146-1-git-send-email-Sandeep.Singh@amd.com>

On Wed, Aug 23, 2017 at 04:26:00PM +0530, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@amd.com>
> 
> The following commit cause a regression on ATI chipsets.
> 'commit e788787ef4f9 ("usb:xhci:Add quirk for Certain
> failing HP keyboard on reset after resume")'
> 
> This causes pinfo->smbus_dev to be wrongly set to NULL on
> systems with the ATI chipset that this function checks for first.
> 
> Added conditional check for AMD chipsets to avoid the overwriting
> pinfo->smbus_dev.
> 
> Reported-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Sandeep Singh <Sandeep.Singh@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>

A "Fixes:" tag here would be good, as would a "cc:
stable@vger.kernel.org" right?

And you have tested this out well, right?

thanks,

greg k-h

  reply	other threads:[~2017-08-23 23:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 10:56 [PATCH] usb:xhci:Fix regression when ATI chipsets detected Sandeep Singh
2017-08-23 23:03 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-24  4:27 Sandeep Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823230319.GC5193@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Sandeep.Singh@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=ben@decadent.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.