From: Christoph Hellwig <hch@lst.de>
To: Shaohua Li <shli@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/6] raid5: remove a call to get_start_sect
Date: Thu, 24 Aug 2017 11:18:23 +0200 [thread overview]
Message-ID: <20170824091823.GC20189@lst.de> (raw)
In-Reply-To: <20170823182338.einsyonnfucyn73y@kernel.org>
On Wed, Aug 23, 2017 at 11:23:38AM -0700, Shaohua Li wrote:
> On Wed, Aug 23, 2017 at 07:10:28PM +0200, Christoph Hellwig wrote:
> > The block layer always remaps partitions before calling into the
> > ->make_request methods of drivers. Thus the call to get_start_sect in
> > in_chunk_boundary will always return 0 and can be removed.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > drivers/md/raid5.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> > index 0fc2748aaf95..d687aeb1b538 100644
> > --- a/drivers/md/raid5.c
> > +++ b/drivers/md/raid5.c
> > @@ -5092,10 +5092,12 @@ static int raid5_congested(struct mddev *mddev, int bits)
> > static int in_chunk_boundary(struct mddev *mddev, struct bio *bio)
> > {
> > struct r5conf *conf = mddev->private;
> > - sector_t sector = bio->bi_iter.bi_sector + get_start_sect(bio->bi_bdev);
> > + sector_t sector = bio->bi_iter.bi_sector;
> > unsigned int chunk_sectors;
> > unsigned int bio_sectors = bio_sectors(bio);
> >
> > + WARN_ON_ONCE(bio->bi_partno);
> > +
Meh, of course bi_partno is only added a few patches later, so this
breaks bisectability. But given that the patch is already in there's
probably nothing I can do here.
next prev parent reply other threads:[~2017-08-24 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 17:10 don't require a struct block_device to submit a bio Christoph Hellwig
2017-08-23 17:10 ` [PATCH 1/6] btrfs: index check-integrity state hash by a dev_t Christoph Hellwig
2017-08-23 17:45 ` Liu Bo
2017-08-23 17:10 ` [PATCH 2/6] raid5: remove a call to get_start_sect Christoph Hellwig
2017-08-23 18:23 ` Shaohua Li
2017-08-24 9:18 ` Christoph Hellwig [this message]
2017-08-23 17:10 ` [PATCH 3/6] block: reject attempts to allocate more than DISK_MAX_PARTS partitions Christoph Hellwig
2017-08-23 17:10 ` [PATCH 4/6] block: add a __disk_get_part helper Christoph Hellwig
2017-08-23 17:10 ` [PATCH 5/6] block: cache the partition index in struct block_device Christoph Hellwig
2017-08-23 17:10 ` [PATCH 6/6] block: replace bi_bdev with a gendisk pointer and partitions index Christoph Hellwig
2017-08-23 18:01 ` don't require a struct block_device to submit a bio Christoph Hellwig
2017-08-23 18:04 ` Jens Axboe
2017-08-23 18:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824091823.GC20189@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.