All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC 2/2] x86/mm: PG_translate implies PG_refcounts
Date: Thu, 24 Aug 2017 11:02:33 +0100	[thread overview]
Message-ID: <20170824100233.GA58987@deinos.phlegethon.org> (raw)
In-Reply-To: <20170823155824.11144-3-wei.liu2@citrix.com>

At 16:58 +0100 on 23 Aug (1503507504), Wei Liu wrote:
> After 404595352 ("x86/paging: Enforce PG_external == PG_translate ==
> PG_refcounts"), PG_refcounts and PG_translate always need to be set
> together.
> 
> Squash PG_refcounts to simplify code. All calls paging_mode_refcounts
> are replaced by calls to paging_mode_translate.

Would it be a good idea to merge all three and have only PG_external?

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Acked-by: Tim Deegan <tim@xen.org>

with one adjustment:

>  /* common paging mode bits */
>  #define PG_mode_shift  10 
> -/* Refcounts based on shadow tables instead of guest tables */
> -#define PG_refcounts   (XEN_DOMCTL_SHADOW_ENABLE_REFCOUNT << PG_mode_shift)
>  /* Enable log dirty mode */
>  #define PG_log_dirty   (XEN_DOMCTL_SHADOW_ENABLE_LOG_DIRTY << PG_mode_shift)
>  /* Xen does p2m translation, not guest */

Please add "and handles refcounts" to the comment describing PG_translate.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-08-24 10:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 15:58 [PATCH RFC 0/2] Misc paging code clean up Wei Liu
2017-08-23 15:58 ` [PATCH RFC 1/2] xen: remove CONFIG_PAGING_ASSISTANCE Wei Liu
2017-08-23 16:04   ` Jan Beulich
2017-08-24 10:04     ` Tim Deegan
2017-08-24 10:15       ` Jan Beulich
2017-08-24 10:42   ` Julien Grall
2017-08-23 15:58 ` [PATCH RFC 2/2] x86/mm: PG_translate implies PG_refcounts Wei Liu
2017-08-23 16:18   ` Wei Liu
2017-08-24 10:02   ` Tim Deegan [this message]
2017-08-24 10:05     ` Wei Liu
2017-08-24 10:07       ` Wei Liu
2017-08-24 10:09         ` Andrew Cooper
2017-08-24 10:11           ` Wei Liu
2017-08-24 10:15       ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824100233.GA58987@deinos.phlegethon.org \
    --to=tim@xen.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.