All of lore.kernel.org
 help / color / mirror / Atom feed
From: weiping zhang <zhangweiping@didichuxing.com>
To: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: remove duplicated setting of gd->minors
Date: Thu, 24 Aug 2017 19:57:40 +0800	[thread overview]
Message-ID: <20170824115740.GA18246@localhost.didichuxing.com> (raw)
In-Reply-To: <20170818064923.GA36375@localhost.didichuxing.com>

On Fri, Aug 18, 2017 at 02:49:30PM +0800, weiping zhang wrote:
> gd->minors has been set when call alloc_disk() in sd_probe.
> 
> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com>
> ---
>  drivers/scsi/sd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index bea36ad..c18ca7a 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -3223,7 +3223,6 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
>  
>  	gd->major = sd_major((index & 0xf0) >> 4);
>  	gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00);
> -	gd->minors = SD_MINORS;
>  
>  	gd->fops = &sd_fops;
>  	gd->private_data = &sdkp->driver;
> -- 
> 2.9.4
> 

Hi Martin,

would you please look into this misc patch ?

Thanks

  reply	other threads:[~2017-08-24 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18  6:49 [PATCH] scsi: sd: remove duplicated setting of gd->minors weiping zhang
2017-08-24 11:57 ` weiping zhang [this message]
2017-08-25 21:28 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824115740.GA18246@localhost.didichuxing.com \
    --to=zhangweiping@didichuxing.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.