From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: remove "no-allocation" reservations for file creations
Date: Thu, 24 Aug 2017 14:18:59 +0200 [thread overview]
Message-ID: <20170824121859.GA23392@lst.de> (raw)
In-Reply-To: <20170823202213.GA4796@magnolia>
On Wed, Aug 23, 2017 at 01:22:13PM -0700, Darrick J. Wong wrote:
> Looks ok... but is there a xfstest somewhere that can be coaxed into
> reproducing this?
The QA team that reported this to me required multiple hours to reproduce
it. I think the key is heavy metadata ops in a full fs, but all my
simple attempts to reproduce it failed.
> I'm looking at what this code does and have been
> wondering why it even tries this weird workaround in the first place?
I think this dates to the time where we weren't very strict about
transaction space reservations - it basically plays lose when near
enospc at the cost of rarely shutting down the whole file system
due to a dirty transaction.
next prev parent reply other threads:[~2017-08-24 12:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 8:24 [PATCH] xfs: remove "no-allocation" reservations for file creations Christoph Hellwig
2017-08-23 20:22 ` Darrick J. Wong
2017-08-24 0:47 ` Dave Chinner
2017-08-24 0:57 ` Darrick J. Wong
2017-08-29 18:04 ` Darrick J. Wong
2017-09-03 7:25 ` Christoph Hellwig
2017-09-03 15:31 ` Darrick J. Wong
2017-12-05 1:34 ` Darrick J. Wong
2017-12-05 18:59 ` Darrick J. Wong
2017-12-07 0:02 ` Christoph Hellwig
2017-12-07 0:19 ` Darrick J. Wong
2017-08-24 12:18 ` Christoph Hellwig [this message]
2017-12-07 0:15 ` Darrick J. Wong
2017-12-07 0:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824121859.GA23392@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.