All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rpcbind: Do not mark .service and .socket files executable
Date: Thu, 24 Aug 2017 23:13:14 +0200	[thread overview]
Message-ID: <20170824231314.73e54f07@windsurf> (raw)
In-Reply-To: <20170823234414.3326-1-andrew.smirnov@gmail.com>

Hello,

On Wed, 23 Aug 2017 16:44:14 -0700, Andrey Smirnov wrote:
> Do not mark .service and .socket files executable, otherwise systemd
> will give us a warning about it.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  package/rpcbind/rpcbind.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks. However, we have a few other packages also
installing .service as 755:

package/minidlna/minidlna.mk:   $(INSTALL) -D -m 0755 package/minidlna/minidlnad.service \
package/nss-pam-ldapd/nss-pam-ldapd.mk: $(INSTALL) -m 755 -D package/nss-pam-ldapd/nslcd.service \
package/transmission/transmission.mk:   $(INSTALL) -D -m 0755 $(@D)/daemon/transmission-daemon.service \

Perhaps we want to fix those as well ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2017-08-24 21:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23 23:44 [Buildroot] [PATCH] package/rpcbind: Do not mark .service and .socket files executable Andrey Smirnov
2017-08-24 21:13 ` Thomas Petazzoni [this message]
2017-08-24 21:33   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824231314.73e54f07@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.