All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] configs: add defconfig for TS-7680
Date: Thu, 24 Aug 2017 23:18:04 +0200	[thread overview]
Message-ID: <20170824231804.0d1bc20a@windsurf> (raw)
In-Reply-To: <20170824210700.26877-1-julien.grossholtz@savoirfairelinux.com>

Hello,

On Thu, 24 Aug 2017 17:07:00 -0400, Julien Grossholtz wrote:
> The TS-7680 is an i.MX286 ARM ARM926EJ-S board with 10/100 Ethernet,
> USB port, eMMC and CAN ports.
> 
> The TS-7680 uses a 3.14.28 Linux kernel provided by Technologic Systems:
> https://github.com/embeddedarm/linux-3.14.28-imx28
> 
> U-Boot is not provided as the manufacturer recommends not to update the
> built-in bootloader.
> 
> For more informations please see:
> https://wiki.embeddedarm.com/wiki/TS-7680
> 
> Signed-off-by: Julien Grossholtz <julien.grossholtz@savoirfairelinux.com>

Thanks for this new version, much better! I've applied to the next
branch, with just one change (see below).


> +++ b/configs/ts7680_defconfig
> @@ -0,0 +1,19 @@
> +BR2_arm=y
> +BR2_KERNEL_HEADERS_VERSION=y
> +BR2_DEFAULT_KERNEL_VERSION="3.14.28"

Those two lines were not needed: indeed we prefer to use the option
"Same as kernel being built" (BR2_KERNEL_HEADERS_AS_KERNEL) when the
kernel is also built as part of the defconfig. Since
BR2_KERNEL_HEADERS_AS_KERNEL is the default, it doesn't need to be
specified in the defconfig.

One neat side effect is that it will avoid a double download of the
kernel: with your defconfig, Buildroot was downloading the vanilla
3.14.28 for the kernel headers, and then Git cloning the
vendor-specific kernel tree. With the change I've made, it will use the
vendor-specific Git tree for the kernel headers as well, avoiding the
3.14.28 vanilla kernel download.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-24 21:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 21:07 [Buildroot] [PATCH v3] configs: add defconfig for TS-7680 Julien Grossholtz
2017-08-24 21:18 ` Thomas Petazzoni [this message]
2017-08-24 21:27   ` Julien Grossholtz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824231804.0d1bc20a@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.