From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] libv4l: ensure libv4l gets built, fixes mediastreamer build
Date: Fri, 25 Aug 2017 00:00:40 +0200 [thread overview]
Message-ID: <20170825000040.60ee3942@windsurf> (raw)
In-Reply-To: <20170821205516.20620-1-thomas.petazzoni@free-electrons.com>
Hello,
On Mon, 21 Aug 2017 22:55:14 +0200, Thomas Petazzoni wrote:
> In commit f837251785e9389f53d695ddb8a094707865171b ("package/libv4l:
> allow build of v4l2 utilities on noMMU platforms"), Hugues Fruchet
> added a bunch of patches to libv4l in order to allow the v4l utilities
> to be built on noMMU platforms.
>
> However, as part of those patches, he entirely disabled the build of
> libv4l in static linking configurations, because libv4l uses
> dlopen(). Unfortunately, this breaks the build of applications like
> mediastreamer in static linking configurations, and generally makes
> our libv4l packages a little bit awkward: you can enable it, but it
> doesn't install anything (in static linking configurations).
>
> A closer look shows that dlopen() is only used by libv4l for plugin
> support, and libv4l only provides one single plugin, and its build is
> already conditional. Therefore, this commit adds yet another patch to
> libv4l, which re-enables the build of libv4l, but disables the
> plugin-related logic when plugin support is disabled (and it was
> already automatically disabled in static linking configurations).
>
> While at it, we update the comment in libv4l.mk that lists the patches
> that makes autoreconf necessary.
>
> Fixes the build of mediastreamer:
>
> http://autobuild.buildroot.net/results/af091cfd0508df9395778cdc796f77e95c168410/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Hugues Fruchet <hugues.fruchet@st.com>
> ---
> ...c-drop-disable-libv4l-disable-plugin-supp.patch | 216 +++++++++++++++++++++
> package/libv4l/libv4l.mk | 2 +
> 2 files changed, 218 insertions(+)
> create mode 100644 package/libv4l/0011-configure.ac-drop-disable-libv4l-disable-plugin-supp.patch
Applied to master, thanks. I've added details in the patch about the
upstreaming status: patch has been submitted, feedback is positive from
libv4l maintainer, but waiting for Hugues to comment on the patch.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-08-24 22:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 20:55 [Buildroot] [PATCH 1/3] libv4l: ensure libv4l gets built, fixes mediastreamer build Thomas Petazzoni
2017-08-21 20:55 ` [Buildroot] [PATCH 2/3] vim: add host variant Thomas Petazzoni
2017-08-25 14:03 ` Thomas Petazzoni
2017-09-06 10:27 ` Peter Korsgaard
2017-08-21 20:55 ` [Buildroot] [PATCH 3/3] mediastreamer: add dependency on host-vim Thomas Petazzoni
2017-08-25 14:03 ` Thomas Petazzoni
2017-09-06 10:27 ` Peter Korsgaard
2017-08-24 22:00 ` Thomas Petazzoni [this message]
2017-09-05 7:49 ` [Buildroot] [PATCH 1/3] libv4l: ensure libv4l gets built, fixes mediastreamer build Hugues FRUCHET
2017-09-05 7:57 ` Thomas Petazzoni
2017-09-06 7:59 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825000040.60ee3942@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.