From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions
Date: Thu, 24 Aug 2017 21:12:19 -0400 [thread overview]
Message-ID: <20170825011219.GH2827@bill-the-cat> (raw)
In-Reply-To: <20170824162318.7132066a@windsurf>
On Thu, Aug 24, 2017 at 04:23:18PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 24 Aug 2017 12:16:30 +0200, Wolfgang Denk wrote:
>
> > > In this patch series, I propose to have U-Boot define some sane
> > > defaults for those 4 configuration options, and cleanup all the board
> > > configuration files that were using the default values. This leads to
> > > the removal of 1300+ lines.
> >
> > Would it not be even easier (and less code) to move these
> > definitions to Kconfig settings?
>
> I believe this patch series is a step in that direction. With this
> patch series applied, we can now clearly identify which boards have
> custom values for CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE}, and
> therefore more easily move these from the .h files to defconfig files.
>
> Unless of course we decide that having such custom values
> in .h/defconfig is useless, and we want to drop them entirely. As I
> said in my cover letter, I really don't see why a board configuration
> file (be it a .h or a defconfig) should specify the maximum number of
> command arguments or the maximum size of the Linux kernel command line.
> The choice for such values is totally independent from the HW, but
> rather tied to the specific use of a given board. For the same board,
> most people will find the default value to be OK, some people will need
> a larger number of command arguments or a bigger Linux kernel command
> line.
>
> Let me know what your preference is.
Thanks for doing this. What I think we should do is migrate these to
Kconfig with the fallback values as the 'vanilla' default and use
moveconfig.py -I min2 to see if there's other cases where it's a SoC
thing or similar where other non-default small values were used in order
to reduce the overall footprint.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170824/485d1a9c/attachment.sig>
prev parent reply other threads:[~2017-08-25 1:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 20:58 [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions Thomas Petazzoni
2017-08-23 20:58 ` [U-Boot] [PATCH 1/8] include/config_fallbacks.h: add default for CONFIG_SYS_CBSIZE Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 2/8] include/configs: remove CONFIG_SYS_CBSIZE when the default value is used Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 3/8] include/config_fallbacks.h: change fallback for CONFIG_SYS_PBSIZE Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 4/8] include/configs: drop default definitions of CONFIG_SYS_PBSIZE Thomas Petazzoni
2017-08-25 1:11 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 5/8] include/config_fallbacks.h: add default for CONFIG_SYS_MAXARGS Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 6/8] include/configs: drop default definitions of CONFIG_SYS_MAXARGS Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 7/8] include/configs: remove default values of CONFIG_SYS_BARGSIZE Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:41 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-23 20:59 ` [U-Boot] [PATCH 8/8] include/configs: remove numerous CONFIG_SYS_BARGSIZE definitions Thomas Petazzoni
2017-08-25 1:12 ` Tom Rini
2017-09-04 0:42 ` [U-Boot] [U-Boot, " Tom Rini
2017-08-24 8:05 ` [U-Boot] [PATCH 0/8] Clean up CONFIG_SYS_{CBSIZE, PBSIZE, MAXARGS, BARGSIZE} definitions Chris Packham
2017-08-24 10:16 ` Wolfgang Denk
2017-08-24 14:23 ` Thomas Petazzoni
2017-08-24 18:53 ` Wolfgang Denk
2017-08-24 19:13 ` Thomas Petazzoni
2017-08-25 11:31 ` Dr. Philipp Tomsich
2017-08-25 1:12 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825011219.GH2827@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.