From: Vinod Koul <vinod.koul@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Dan Williams" <dan.j.williams@intel.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Anton Volkov" <avolkov@ispras.ru>,
"Alexey Khoroshilov" <khoroshilov@ispras.ru>,
ldv-project@linuxtesting.org, dmaengine@vger.kernel.org,
geert+renesas@glider.be
Subject: Re: [PATCH v2] rcar-dmac: initialize all data before registering IRQ handler
Date: Fri, 25 Aug 2017 12:28:01 +0530 [thread overview]
Message-ID: <20170825065801.GT3053@localhost> (raw)
In-Reply-To: <877exxcu9q.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Aug 21, 2017 at 06:31:57AM +0000, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Anton Volkov noticed that engine->dev is NULL before
> of_dma_controller_register() in probe.
> Thus there might be a NULL pointer dereference in
> rcar_dmac_chan_start_xfer while accessing chan->chan.device->dev which
> is equal to (&dmac->engine)->dev.
> On same reason, same and similar things will happen if we didn't
> initialize all necessary data before calling register irq function.
> To be more safety code, this patch initialize all necessary data
> before calling register irq function.
Applied after adding subsytem name, thanks
--
~Vinod
prev parent reply other threads:[~2017-08-25 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 6:31 [PATCH v2] rcar-dmac: initialize all data before registering IRQ handler Kuninori Morimoto
2017-08-25 6:58 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825065801.GT3053@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=avolkov@ispras.ru \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=khoroshilov@ispras.ru \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.